feat(invalid-dependency): add invalidAsyncFunction which rejects with an Error#1719
feat(invalid-dependency): add invalidAsyncFunction which rejects with an Error#1719trivikr merged 9 commits intoaws:masterfrom
Conversation
|
Looks good. Although it mixes in a few model change like this one: https://github.com/aws/aws-sdk-js-v3/pull/1719/files#diff-07e0dd2a293b067508c4dafbf9853415671ac466bbe6a8a092006424af26092fR25. I will approve it but please remove the diffs from the commands and models. |
7c0968d to
115c767
Compare
Codecov Report
@@ Coverage Diff @@
## master #1719 +/- ##
==========================================
- Coverage 79.77% 79.77% -0.01%
==========================================
Files 325 331 +6
Lines 12087 12586 +499
Branches 2553 2675 +122
==========================================
+ Hits 9643 10041 +398
- Misses 2444 2545 +101
Continue to review full report at Codecov.
|
115c767 to
a5ed281
Compare
a5ed281 to
2d76860
Compare
This was an issue with a bad merge in master, which was fixed in #1732 This PR is now rebased, and ready for review. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Fixes: #1717
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.