fix(abort-controller): make AbortSignal WHATWG Spec compliant#1699
Merged
trivikr merged 2 commits intoaws:masterfrom Nov 19, 2020
Merged
fix(abort-controller): make AbortSignal WHATWG Spec compliant#1699trivikr merged 2 commits intoaws:masterfrom
trivikr merged 2 commits intoaws:masterfrom
Conversation
alexforsyth
approved these changes
Nov 19, 2020
Contributor
alexforsyth
left a comment
There was a problem hiding this comment.
LGTM, after build passes
Codecov Report
@@ Coverage Diff @@
## master #1699 +/- ##
==========================================
- Coverage 79.77% 79.76% -0.02%
==========================================
Files 325 329 +4
Lines 12087 12574 +487
Branches 2553 2671 +118
==========================================
+ Hits 9643 10030 +387
- Misses 2444 2544 +100
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes: #1159
Description of changes:
Makes AbortSignal WHATWG Spec compliant.
Verified that no errors were thrown with the following code:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.