fix(client-s3): throw errors with 200 status code#1657
Merged
AllanZhengYP merged 1 commit intoaws:masterfrom Nov 6, 2020
Merged
fix(client-s3): throw errors with 200 status code#1657AllanZhengYP merged 1 commit intoaws:masterfrom
AllanZhengYP merged 1 commit intoaws:masterfrom
Conversation
8e81e65 to
e514ca2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1657 +/- ##
==========================================
- Coverage 79.77% 79.71% -0.07%
==========================================
Files 325 328 +3
Lines 12087 12573 +486
Branches 2553 2670 +117
==========================================
+ Hits 9643 10022 +379
- Misses 2444 2551 +107
Continue to review full report at Codecov.
|
trivikr
approved these changes
Nov 6, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
In case of internal error or connection termination, some S3 operations(CopyObject, UploadPartCopy, CompleteMultiPartUpload) may return error with 200 status code. The change adds customization to throw exceptions when:
<Error>;Related PR: aws/aws-sdk-js#3259
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.