feat: update client description to add keywords#1631
Merged
trivikr merged 4 commits intoaws:masterfrom Oct 27, 2020
Merged
Conversation
for dir in ./clients/*; do (cd "$dir" && sed -i '/"description"/d' ./package.json); done
alexforsyth
approved these changes
Oct 27, 2020
Contributor
alexforsyth
left a comment
alexforsyth
left a comment
There was a problem hiding this comment.
LGTM! Is this for search engines?
Member
Author
Yup, for npm search to be specific. |
Member
Author
|
The CI failure is intermittent one discussed in #1539 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #1623
Description of changes:
Updates client description to add keywords. The sdkId has client names in lowercase, so current fix is the best approximation to help with npm search. A follow-up PR needs to be created to use actual sdkId provided by models.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.