Skip to content

fix: add loggerMiddleware in build step#1520

Merged
trivikr merged 2 commits intoaws:masterfrom
trivikr:logger-middleware-build
Sep 14, 2020
Merged

fix: add loggerMiddleware in build step#1520
trivikr merged 2 commits intoaws:masterfrom
trivikr:logger-middleware-build

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Sep 14, 2020

Issue #, if available:
Fixes: #1488 (comment)

Description of changes:
adds loggerMiddleware in build step so that values populated in metadata by retryMiddleware (attempts and totalRetryDelay) are visible

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1520 into master will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
- Coverage   79.80%   79.67%   -0.14%     
==========================================
  Files         298      300       +2     
  Lines       11502    11653     +151     
  Branches     2475     2486      +11     
==========================================
+ Hits         9179     9284     +105     
- Misses       2323     2369      +46     
Impacted Files Coverage Δ
...l_tests/aws-json/commands/EmptyOperationCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
...ts/aws-query/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
.../aws-restxml/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
...aws-restjson/commands/NoInputAndNoOutputCommand.ts 90.00% <0.00%> (-10.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlBlobsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlEnumsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
protocol_tests/aws-ec2/commands/XmlListsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...rotocol_tests/aws-query/commands/XmlMapsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...otocol_tests/aws-query/commands/XmlBlobsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
...otocol_tests/aws-query/commands/XmlEnumsCommand.ts 95.00% <0.00%> (-5.00%) ⬇️
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ee3af...01245ca. Read the comment docs.

@trivikr trivikr merged commit fece417 into aws:master Sep 14, 2020
@trivikr trivikr deleted the logger-middleware-build branch September 14, 2020 18:01
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

attempts and totalRetryDelay are not present in logger metadata

3 participants