feat: log metadata/input/output/request/response#1478
Merged
trivikr merged 3 commits intoaws:masterfrom Aug 31, 2020
Merged
Conversation
Reason: logger will be passed through context
CodeGen passes options to getXPlugin commands, but loggerMiddleware reads logger from context
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
==========================================
+ Coverage 79.80% 79.83% +0.03%
==========================================
Files 298 298
Lines 11502 11522 +20
Branches 2475 2477 +2
==========================================
+ Hits 9179 9199 +20
Misses 2323 2323
Continue to review full report at Codecov.
|
Member
Author
alexforsyth
reviewed
Aug 31, 2020
alexforsyth
approved these changes
Aug 31, 2020
Contributor
alexforsyth
left a comment
alexforsyth
left a comment
There was a problem hiding this comment.
LGTM, minor feedback.
AllanZhengYP
approved these changes
Aug 31, 2020
Contributor
AllanZhengYP
left a comment
AllanZhengYP
left a comment
There was a problem hiding this comment.
Looks good. Just have a minor comment
This was referenced Sep 1, 2020
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-2037
Description of changes:
log metadata/input/output/request/response
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.