feat: read maxAttempts value from retry-config#1286
Merged
trivikr merged 2 commits intoaws:masterfrom Jun 23, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
==========================================
+ Coverage 73.04% 73.17% +0.13%
==========================================
Files 287 290 +3
Lines 12730 12792 +62
Branches 2922 2936 +14
==========================================
+ Hits 9299 9361 +62
Misses 3431 3431
Continue to review full report at Codecov.
|
alexforsyth
reviewed
Jun 19, 2020
alexforsyth
reviewed
Jun 19, 2020
alexforsyth
approved these changes
Jun 19, 2020
Contributor
alexforsyth
left a comment
There was a problem hiding this comment.
LGTM. Minor comments to be addressed
d1a896b to
e11cef7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow-up to #1284
Description of changes:
read maxAttempts value from retry-config
maxAttemptsis now updated fromnumbertoProvider<string>maxAttemptsis removed fromRetryStrategyinterfaceBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.