Skip to content

Commit c28523f

Browse files
committed
fix(nested-clients): add bundler instructions for browser credential clients
1 parent 6b5b50b commit c28523f

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

packages-internal/nested-clients/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,9 @@
9393
"dist-*/**"
9494
],
9595
"browser": {
96+
"./dist-es/submodules/cognito-identity/runtimeConfig": "./dist-es/submodules/cognito-identity/runtimeConfig.browser",
9697
"./dist-es/submodules/signin/runtimeConfig": "./dist-es/submodules/signin/runtimeConfig.browser",
98+
"./dist-es/submodules/sso/runtimeConfig": "./dist-es/submodules/sso/runtimeConfig.browser",
9799
"./dist-es/submodules/sso-oidc/runtimeConfig": "./dist-es/submodules/sso-oidc/runtimeConfig.browser",
98100
"./dist-es/submodules/sts/runtimeConfig": "./dist-es/submodules/sts/runtimeConfig.browser"
99101
},

scripts/validation/submodules-linter.js

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ for (const submodulePackage of submodulePackages) {
4141
}
4242
}
4343
// package.json metadata.
44+
const pushPkgJson = () => {
45+
fs.writeFileSync(path.join(root, "package.json"), JSON.stringify(pkgJson, null, 2) + "\n");
46+
};
47+
4448
if (!pkgJson.exports[`./${submodule}`]) {
4549
errors.push(`${submodule} submodule is missing exports statement in package.json`);
4650
pkgJson.exports[`./${submodule}`] = {
@@ -50,14 +54,23 @@ for (const submodulePackage of submodulePackages) {
5054
import: `./dist-es/submodules/${submodule}/index.js`,
5155
require: `./dist-cjs/submodules/${submodule}/index.js`,
5256
};
53-
fs.writeFileSync(path.join(root, "package.json"), JSON.stringify(pkgJson, null, 2) + "\n");
57+
pushPkgJson();
58+
}
59+
if (submodulePackage === "nested-clients") {
60+
if (!pkgJson.browser[`./dist-es/submodules/${submodule}/runtimeConfig`]) {
61+
pkgJson.browser[
62+
`./dist-es/submodules/${submodule}/runtimeConfig`
63+
] = `./dist-es/submodules/${submodule}/runtimeConfig.browser`;
64+
errors.push(`${submodule} is missing browser replacement directive.`);
65+
}
66+
pushPkgJson();
5467
}
5568
if (!pkgJson.files.includes(`./${submodule}.js`) || !pkgJson.files.includes(`./${submodule}.d.ts`)) {
5669
pkgJson.files.push(`./${submodule}.js`);
5770
pkgJson.files.push(`./${submodule}.d.ts`);
5871
errors.push(`package.json files array missing ${submodule}.js compatibility redirect file.`);
5972
pkgJson.files = [...new Set(pkgJson.files)].sort();
60-
fs.writeFileSync(path.join(root, "package.json"), JSON.stringify(pkgJson, null, 2) + "\n");
73+
pushPkgJson();
6174
}
6275
// tsconfig metadata.
6376
for (const [kind, tsconfig] of Object.entries(tsconfigs)) {

0 commit comments

Comments
 (0)