chore(packages): reapply eslint rules (#7789)

Author: kuhe

.eslintrc.js

@@ -8,7 +8,7 @@ module.exports = {
     // Uses the recommended rules from the @typescript-eslint/eslint-plugin
     "plugin:@typescript-eslint/recommended",
   ],
-  plugins: ["@typescript-eslint", "simple-import-sort", "eslint-plugin-sort-export-all", "eslint-plugin-tsdoc"],
+  plugins: ["@typescript-eslint", "simple-import-sort", "eslint-plugin-sort-export-all", "eslint-plugin-tsdoc", "n"],
   rules: {
     /** Turn off strict enforcement */
     "@typescript-eslint/ban-types": "off",
@@ -29,6 +29,7 @@ module.exports = {
     "simple-import-sort/imports": "error",
     "sort-export-all/sort-export-all": "error",
     "@typescript-eslint/consistent-type-imports": "error",
+    "n/prefer-node-protocol": "error",
   },
   ignorePatterns: [
     "packages/nested-clients/src/submodules/**/protocols/*.ts",
@@ -67,6 +68,7 @@ module.exports = {
       files: ["**/*.js"],
       rules: {
         "tsdoc/syntax": "off",
+        "n/prefer-node-protocol": "error",
       },
     },
   ],

lib/lib-storage/src/Upload.spec.ts

@@ -1,6 +1,6 @@
+import type { CompleteMultipartUploadCommandOutput } from "@aws-sdk/client-s3";
 import {
   CompleteMultipartUploadCommand,
-  CompleteMultipartUploadCommandOutput,
   CreateMultipartUploadCommand,
   PutObjectCommand,
   PutObjectTaggingCommand,
@@ -9,10 +9,11 @@ import {
   UploadPartCommand,
 } from "@aws-sdk/client-s3";
 import { AbortController } from "@smithy/abort-controller";
-import { EventEmitter, Readable } from "stream";
+import { EventEmitter, Readable } from "node:stream";
 import { afterAll, afterEach, beforeEach, describe, expect, test as it, vi } from "vitest";
 
-import { Progress, Upload } from "./index";
+import type { Progress } from "./index";
+import { Upload } from "./index";
 
 vi.mock("@aws-sdk/client-s3");
 

lib/lib-storage/src/Upload.ts

@@ -1,36 +1,37 @@
-import {
-  AbortMultipartUploadCommand,
-  ChecksumAlgorithm,
+import type {
   CompletedPart,
-  CompleteMultipartUploadCommand,
   CompleteMultipartUploadCommandInput,
   CompleteMultipartUploadCommandOutput,
-  CreateMultipartUploadCommand,
   CreateMultipartUploadCommandInput,
   CreateMultipartUploadCommandOutput,
-  PutObjectCommand,
   PutObjectCommandInput,
-  PutObjectTaggingCommand,
   S3Client,
   Tag,
-  UploadPartCommand,
   UploadPartCommandInput,
 } from "@aws-sdk/client-s3";
-import { AbortController } from "@smithy/abort-controller";
 import {
-  EndpointParameterInstructionsSupplier,
-  getEndpointFromInstructions,
-  toEndpointV1,
-} from "@smithy/middleware-endpoint";
-import { HttpRequest } from "@smithy/protocol-http";
+  AbortMultipartUploadCommand,
+  ChecksumAlgorithm,
+  CompleteMultipartUploadCommand,
+  CreateMultipartUploadCommand,
+  PutObjectCommand,
+  PutObjectTaggingCommand,
+  UploadPartCommand,
+} from "@aws-sdk/client-s3";
+import { AbortController } from "@smithy/abort-controller";
+import type { EndpointParameterInstructionsSupplier } from "@smithy/middleware-endpoint";
+import { getEndpointFromInstructions, toEndpointV1 } from "@smithy/middleware-endpoint";
+import type { HttpRequest } from "@smithy/protocol-http";
 import { extendedEncodeURIComponent } from "@smithy/smithy-client";
 import type { AbortController as IAbortController, AbortSignal as IAbortSignal, Endpoint } from "@smithy/types";
+// eslint-disable-next-line n/prefer-node-protocol
 import { EventEmitter } from "events";
 
 import { byteLength } from "./byteLength";
-import { BYTE_LENGTH_SOURCE, byteLengthSource } from "./byteLengthSource";
+import type { BYTE_LENGTH_SOURCE } from "./byteLengthSource";
+import { byteLengthSource } from "./byteLengthSource";
 import { getChunk } from "./chunker";
-import { BodyDataTypes, Options, Progress } from "./types";
+import type { BodyDataTypes, Options, Progress } from "./types";
 
 export interface RawDataPart {
   partNumber: number;

lib/lib-storage/src/byteLength.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line n/prefer-node-protocol
 import { Buffer } from "buffer"; // do not remove this import: Node.js buffer or buffer NPM module for browser.
 
 import { runtimeConfig } from "./runtimeConfig";

lib/lib-storage/src/chunker.ts

@@ -1,11 +1,13 @@
+// eslint-disable-next-line n/prefer-node-protocol
 import { Buffer } from "buffer"; // do not remove this import: Node.js buffer or buffer NPM module for browser.
+// eslint-disable-next-line n/prefer-node-protocol
 import { Readable } from "stream";
 
 import { getChunkStream } from "./chunks/getChunkStream";
 import { getChunkUint8Array } from "./chunks/getChunkUint8Array";
 import { getDataReadable } from "./chunks/getDataReadable";
 import { getDataReadableStream } from "./chunks/getDataReadableStream";
-import { BodyDataTypes } from "./types";
+import type { BodyDataTypes } from "./types";
 import type { RawDataPart } from "./Upload";
 
 export const getChunk = (data: BodyDataTypes, partSize: number): AsyncGenerator<RawDataPart, void, undefined> => {

lib/lib-storage/src/chunks/getChunkStream.ts

@@ -1,6 +1,7 @@
+// eslint-disable-next-line n/prefer-node-protocol
 import { Buffer } from "buffer"; // do not remove this import: Node.js buffer or buffer NPM module for browser.
 
-import { RawDataPart } from "../Upload";
+import type { RawDataPart } from "../Upload";
 
 interface Buffers {
   chunks: Uint8Array[];

lib/lib-storage/src/chunks/getChunkUint8Array.spec.ts

@@ -2,7 +2,7 @@ import { describe, expect, test as it } from "vitest";
 
 import { byteLength } from "../byteLength";
 import { BYTE_LENGTH_SOURCE, byteLengthSource } from "../byteLengthSource";
-import { RawDataPart } from "../Upload";
+import type { RawDataPart } from "../Upload";
 import { getChunkUint8Array } from "./getChunkUint8Array";
 
 describe(getChunkUint8Array.name, () => {

lib/lib-storage/src/chunks/getChunkUint8Array.ts

@@ -1,4 +1,4 @@
-import { RawDataPart } from "../Upload";
+import type { RawDataPart } from "../Upload";
 
 export async function* getChunkUint8Array(
   data: Uint8Array,

lib/lib-storage/src/chunks/getDataReadable.spec.ts

@@ -1,12 +1,12 @@
-import { Readable } from "stream";
+import { Readable } from "node:stream";
 import { describe, expect, test as it } from "vitest";
 
 import { byteLength } from "../byteLength";
-import { RawDataPart as DataPart } from "../Upload";
+import type { RawDataPart as DataPart } from "../Upload";
 import { getChunkStream as chunkFromReadable } from "./getChunkStream";
 import { getDataReadable } from "./getDataReadable";
 
-const fs = require("fs");
+const fs = require("node:fs");
 
 describe(chunkFromReadable.name, () => {
   // larger than the 5mb min chunk size.

lib/lib-storage/src/chunks/getDataReadable.ts

@@ -1,5 +1,7 @@
+// eslint-disable-next-line n/prefer-node-protocol
 import { Buffer } from "buffer"; // do not remove this import: Node.js buffer or buffer NPM module for browser.
-import { Readable } from "stream";
+// eslint-disable-next-line n/prefer-node-protocol
+import type { Readable } from "stream";
 
 export async function* getDataReadable(data: Readable): AsyncGenerator<Uint8Array> {
   for await (const chunk of data) {