Skip to content

Remove simple-git-hooks on postinstall #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 2, 2022

The hooks are needed for local development, and need to be run just once.
The instructions can be added in CONTRIBUTING.md when more developers start contributing to the project.

Existing of this postinstall script is failing installation of [email protected]

$ npm install -g [email protected]
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/aws-sdk-js-codemod/node_modules/jscodeshift
npm WARN   jscodeshift@"0.13.1" from [email protected]
npm WARN   node_modules/aws-sdk-js-codemod
npm WARN     aws-sdk-js-codemod@"0.0.2" from the root project
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer jscodeshift@"^0.7.0 || ^0.8.0 || ^0.9.0 || ^0.10.0 || ^0.11.0" from [email protected]
npm WARN node_modules/aws-sdk-js-codemod/node_modules/jscodeshift-find-imports
npm WARN   jscodeshift-find-imports@"2.0.4" from [email protected]
npm WARN   node_modules/aws-sdk-js-codemod
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/jscodeshift
npm WARN   peer jscodeshift@"^0.7.0 || ^0.8.0 || ^0.9.0 || ^0.10.0 || ^0.11.0" from [email protected]
npm WARN   node_modules/aws-sdk-js-codemod/node_modules/jscodeshift-find-imports
npm WARN     jscodeshift-find-imports@"2.0.4" from [email protected]
npm WARN     node_modules/aws-sdk-js-codemod
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: See https://github.com/lydell/source-map-resolve#deprecated
npm ERR! code 127
npm ERR! path /Users/trivikr/.fnm/node-versions/v16.14.0/installation/lib/node_modules/aws-sdk-js-codemod
npm ERR! command failed
npm ERR! command sh -c simple-git-hooks
npm ERR! sh: simple-git-hooks: command not found

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/trivikr/.npm/_logs/2022-03-02T19_01_34_525Z-debug-0.log

@trivikr trivikr changed the title Run npx simple-git-hooks on postinstall Remove simple-git-hooks on postinstall Mar 2, 2022
@trivikr trivikr merged commit 3c20ee0 into main Mar 2, 2022
@trivikr trivikr deleted the update-post-install branch March 2, 2022 19:06
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant