Optimize/directory traversal (#2970)

Author: Gofastasf

.changelog/67431bb2-f939-4912-b813-adcc349a4bf5.json

@@ -0,0 +1,9 @@
+{
+    "id": "67431bb2-f939-4912-b813-adcc349a4bf5",
+    "type": "Announcement",
+    "description": "Refactor filepath.Walk to filepath.WalkDir",
+    "collapse": false,
+    "modules": [
+        "internal/ini"
+    ]
+}

internal/ini/ini_test.go

@@ -3,6 +3,7 @@ package ini
 import (
 	"encoding/json"
 	"fmt"
+	"io/fs"
 	"io/ioutil"
 	"os"
 	"path/filepath"
@@ -12,13 +13,13 @@ import (
 
 func TestValidDataFiles(t *testing.T) {
 	const expectedFileSuffix = "_expected"
-	err := filepath.Walk(filepath.Join("testdata", "valid"),
-		func(path string, info os.FileInfo, fnErr error) (err error) {
+	err := filepath.WalkDir(filepath.Join("testdata", "valid"),
+		func(path string, d fs.DirEntry, fnErr error) (err error) {
 			if strings.HasSuffix(path, expectedFileSuffix) {
 				return nil
 			}
 
-			if info.IsDir() {
+			if d.IsDir() {
 				return nil
 			}
 

internal/repotools/cmd/syncAPIModels/main.go

@@ -5,6 +5,7 @@ import (
 	"flag"
 	"fmt"
 	"io"
+	"io/fs"
 	"log"
 	"os"
 	"path/filepath"
@@ -74,13 +75,13 @@ type SourceModel struct {
 func findSmithyModels(modelPath string) (map[string]SourceModel, error) {
 	models := map[string]SourceModel{}
 
-	err := filepath.Walk(modelPath,
-		func(path string, info os.FileInfo, err error) error {
-			if err != nil || info.IsDir() {
+	err := filepath.WalkDir(modelPath,
+		func(path string, d fs.DirEntry, err error) error {
+			if err != nil || d.IsDir() {
 				return err
 			}
 
-			if filepath.Ext(info.Name()) != ".json" {
+			if filepath.Ext(d.Name()) != ".json" {
 				return nil
 			}