Skip to content

Conversation

seebees
Copy link
Contributor

@seebees seebees commented May 8, 2025

All possible values of a PutObjectRequest need to be supported when enabling multiparty put object.

This PR adds support and the S3EC will now fail closed in the case of new options. This is preferred to silently dropping the value.

This is a fix for: #457

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

All possible values of a PutObjectRequest need to be supported when enabling multiparty put object.

This PR adds support and the S3EC will now fail closed in the case of new options. This is preferred to silently dropping the value.
@seebees seebees requested a review from a team as a code owner May 8, 2025 20:40
Copy link
Contributor

@kessplas kessplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta comment: Can we add an integration test for this? i'm thinking something which sets an option (probably just one i.e. storage class is fine) then checks that the GetObjectResponse has that member? (I can provide you with an example.)

Copy link
Contributor

@kessplas kessplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kessplas kessplas merged commit 99cce95 into main May 8, 2025
20 of 21 checks passed
@kessplas kessplas deleted the seebees/fix-457 branch May 8, 2025 23:22
seebees added a commit that referenced this pull request May 9, 2025
Add more details to the error message in #458.

This adds workaround suggestions and more details.
@seebees seebees mentioned this pull request May 9, 2025
1 task
seebees added a commit that referenced this pull request May 9, 2025
Add more details to the error message in #458.

This adds workaround suggestions and more details.
josecorella pushed a commit that referenced this pull request May 12, 2025
## [3.3.4](v3.3.3...v3.3.4) (2025-05-12)

### Fixes

* Add details to error message ([#459](#459)) ([0d32b4a](0d32b4a)), closes [#458](#458)
* Support all PutObjectRequest fields ([#458](#458)) ([99cce95](99cce95))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants