Skip to content

Commit 29cfae6

Browse files
Remove AVX conditional from cmake script (#2958)
Duplicate conditional logic in both perlasm file and in cmake script. Rest of perlasm does in inline, so remove the cmake logic.
1 parent 43721b5 commit 29cfae6

File tree

1 file changed

+13
-32
lines changed

1 file changed

+13
-32
lines changed

crypto/CMakeLists.txt

Lines changed: 13 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,8 @@ if(PERL_EXECUTABLE)
176176
perlasm(cipher_extra/aes128gcmsiv-x86_64.${ASM_EXT} cipher_extra/asm/aes128gcmsiv-x86_64.pl)
177177
perlasm(cipher_extra/chacha20_poly1305_x86_64.${ASM_EXT} cipher_extra/asm/chacha20_poly1305_x86_64.pl)
178178
perlasm(cipher_extra/chacha20_poly1305_armv8.${ASM_EXT} cipher_extra/asm/chacha20_poly1305_armv8.pl)
179-
if(NOT MY_ASSEMBLER_IS_TOO_OLD_FOR_AVX)
180-
perlasm(cipher_extra/aesni-sha1-x86_64.${ASM_EXT} cipher_extra/asm/aesni-sha1-x86_64.pl)
181-
perlasm(cipher_extra/aesni-sha256-x86_64.${ASM_EXT} cipher_extra/asm/aesni-sha256-x86_64.pl)
182-
endif()
179+
perlasm(cipher_extra/aesni-sha1-x86_64.${ASM_EXT} cipher_extra/asm/aesni-sha1-x86_64.pl)
180+
perlasm(cipher_extra/aesni-sha256-x86_64.${ASM_EXT} cipher_extra/asm/aesni-sha256-x86_64.pl)
183181
perlasm(test/trampoline-armv4.${ASM_EXT} test/asm/trampoline-armv4.pl)
184182
perlasm(test/trampoline-armv8.${ASM_EXT} test/asm/trampoline-armv8.pl)
185183
perlasm(test/trampoline-ppc.${ASM_EXT} test/asm/trampoline-ppc.pl)
@@ -264,34 +262,17 @@ if(ARCH STREQUAL "x86")
264262
endif()
265263

266264
if(ARCH STREQUAL "x86_64")
267-
if(MY_ASSEMBLER_IS_TOO_OLD_FOR_AVX)
268-
# CryptoAlg-1091:
269-
# Stitch code |aesni-sha1/256-x86_64.${ASM_EXT}| are not enabled due
270-
# to some build issues and lack of tools to measure the performance gap.
271-
# The disable is safer choice because |EVP_aes_128/256_cbc_hmac_sha1/256|
272-
# are deprecated.
273-
set(
274-
CRYPTO_ARCH_SOURCES
275-
276-
chacha/chacha-x86_64.${ASM_EXT}
277-
cipher_extra/chacha20_poly1305_x86_64.${ASM_EXT}
278-
cipher_extra/aes128gcmsiv-x86_64.${ASM_EXT}
279-
test/trampoline-x86_64.${ASM_EXT}
280-
hrss/asm/poly_rq_mul.S
281-
)
282-
else()
283-
set(
284-
CRYPTO_ARCH_SOURCES
285-
286-
chacha/chacha-x86_64.${ASM_EXT}
287-
cipher_extra/chacha20_poly1305_x86_64.${ASM_EXT}
288-
cipher_extra/aes128gcmsiv-x86_64.${ASM_EXT}
289-
cipher_extra/aesni-sha1-x86_64.${ASM_EXT}
290-
cipher_extra/aesni-sha256-x86_64.${ASM_EXT}
291-
test/trampoline-x86_64.${ASM_EXT}
292-
hrss/asm/poly_rq_mul.S
293-
)
294-
endif()
265+
set(
266+
CRYPTO_ARCH_SOURCES
267+
268+
chacha/chacha-x86_64.${ASM_EXT}
269+
cipher_extra/chacha20_poly1305_x86_64.${ASM_EXT}
270+
cipher_extra/aes128gcmsiv-x86_64.${ASM_EXT}
271+
cipher_extra/aesni-sha1-x86_64.${ASM_EXT}
272+
cipher_extra/aesni-sha256-x86_64.${ASM_EXT}
273+
test/trampoline-x86_64.${ASM_EXT}
274+
hrss/asm/poly_rq_mul.S
275+
)
295276
endif()
296277

297278
if(GO_EXECUTABLE)

0 commit comments

Comments
 (0)