fix(iam): throw error when statement id is invalid (#34819)

Author: camerondurham

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.cluster-encrypt-ephemeral-storage.js.snapshot/aws-ecs-ephemeral-integ.template.json

@@ -435,7 +435,7 @@
         "Service": "fargate.amazonaws.com"
        },
        "Resource": "*",
-       "Sid": "Allow generate data key access for Fargate tasks."
+       "Sid": "AllowGenerateDataKeyAccessForFargateTasks"
       },
       {
        "Action": "kms:CreateGrant",
@@ -458,7 +458,7 @@
         "Service": "fargate.amazonaws.com"
        },
        "Resource": "*",
-       "Sid": "Allow grant creation permission for Fargate tasks."
+       "Sid": "AllowGrantCreationPermissionForFargateTasks"
       }
      ],
      "Version": "2012-10-17"
@@ -526,7 +526,7 @@
         "Service": "fargate.amazonaws.com"
        },
        "Resource": "*",
-       "Sid": "Allow generate data key access for Fargate tasks."
+       "Sid": "AllowGenerateDataKeyAccessForFargateTasks"
       },
       {
        "Action": "kms:CreateGrant",
@@ -552,7 +552,7 @@
         "Service": "fargate.amazonaws.com"
        },
        "Resource": "*",
-       "Sid": "Allow grant creation permission for Fargate tasks."
+       "Sid": "AllowGrantCreationPermissionForFargateTasks"
       }
      ],
      "Version": "2012-10-17"

packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/integ.cluster-encrypt-ephemeral-storage.js.snapshot/tree.json

@@ -103,7 +103,7 @@ const originalBus = new EventBus(crossAccountStack, 'bus', {
 });
 testingStack.addDependency(crossAccountStack);
 
-originalBus.grantPutEventsTo(new AccountPrincipal(account), 'cross-account-access-sid');
+originalBus.grantPutEventsTo(new AccountPrincipal(account), 'crossAccountAccessSid');
 
 const integ = new IntegTest(app, 'CrossAccountDeploy', {
   testCases: [

packages/@aws-cdk-testing/framework-integ/test/aws-events/test/integ.eventbus-cross-account-grants.ts

@@ -43,7 +43,7 @@
     "Name": "StackBusAA0A1E4B"
    }
   },
-  "BuscdkStatement1D7D87B9D": {
+  "BuscdkStatement17E48E06E": {
    "Type": "AWS::Events::EventBusPolicy",
    "Properties": {
     "EventBusName": {
@@ -66,12 +66,12 @@
        "Arn"
       ]
      },
-     "Sid": "cdk-Statement1"
+     "Sid": "cdkStatement1"
     },
-    "StatementId": "cdk-Statement1"
+    "StatementId": "cdkStatement1"
    }
   },
-  "BuscdkStatement2341A5B58": {
+  "BuscdkStatement2D6A35B77": {
    "Type": "AWS::Events::EventBusPolicy",
    "Properties": {
     "EventBusName": {
@@ -94,9 +94,9 @@
        "Arn"
       ]
      },
-     "Sid": "cdk-Statement2"
+     "Sid": "cdkStatement2"
     },
-    "StatementId": "cdk-Statement2"
+    "StatementId": "cdkStatement2"
    }
   }
  },