Skip to content

Commit e457942

Browse files
committed
Fix integration test
1 parent 98406ba commit e457942

File tree

6 files changed

+66
-34
lines changed

6 files changed

+66
-34
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/aws-ecr-integ-stack.assets.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/aws-ecr-integ-stack.template.json

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,11 +103,30 @@
103103
"Arn"
104104
]
105105
},
106-
"Id": "OnEventTargetLambda"
106+
"Id": "Target0"
107107
}
108108
]
109109
}
110110
},
111+
"RepoOnEventOnEventTargetLambdaAllowEventRuleawsecrintegstackLambdaFunctionB6045AA7FBA3AA33": {
112+
"Type": "AWS::Lambda::Permission",
113+
"Properties": {
114+
"Action": "lambda:InvokeFunction",
115+
"FunctionName": {
116+
"Fn::GetAtt": [
117+
"LambdaFunctionBF21E41F",
118+
"Arn"
119+
]
120+
},
121+
"Principal": "events.amazonaws.com",
122+
"SourceArn": {
123+
"Fn::GetAtt": [
124+
"RepoOnEventOnEventTargetLambda2934FA99",
125+
"Arn"
126+
]
127+
}
128+
}
129+
},
111130
"LambdaFunctionServiceRoleC555A460": {
112131
"Type": "AWS::IAM::Role",
113132
"Properties": {

packages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/manifest.json

Lines changed: 7 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/tree.json

Lines changed: 31 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { IntegTest } from '@aws-cdk/integ-tests-alpha';
33
import * as ecr from 'aws-cdk-lib/aws-ecr';
44
import * as iam from 'aws-cdk-lib/aws-iam';
55
import * as lambda from 'aws-cdk-lib/aws-lambda';
6+
import { LambdaFunction } from 'aws-cdk-lib/aws-events-targets';
67

78
const app = new cdk.App();
89
const stack = new cdk.Stack(app, 'aws-ecr-integ-stack');
@@ -30,15 +31,14 @@ new cdk.CfnOutput(stack, 'RepositoryURI', {
3031
});
3132

3233
const repoOnEvent = new ecr.Repository(stack, 'RepoOnEvent');
33-
const lambdaFunction = new lambda.Function(stack, 'LambdaFunction', {
34+
const lambdaHandler = new lambda.Function(stack, 'LambdaFunction', {
3435
runtime: lambda.Runtime.PYTHON_3_12,
3536
code: lambda.Code.fromInline('# dummy func'),
3637
handler: 'index.handler',
3738
});
39+
3840
repoOnEvent.onEvent('OnEventTargetLambda', {
39-
target: {
40-
bind: () => ({ arn: lambdaFunction.functionArn, id: 'OnEventTargetLambda' }),
41-
},
41+
target: new LambdaFunction(lambdaHandler),
4242
});
4343

4444
new IntegTest(app, 'cdk-ecr-integ-test-basic', {

packages/aws-cdk-lib/aws-ecr/README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -217,15 +217,13 @@ You can publish repository events to a CloudWatch event rule with `onEvent`:
217217
import * as lambda from 'aws-cdk-lib/aws-lambda';
218218

219219
const repo = new ecr.Repository(this, 'Repo');
220-
const lambdaFunction = new lambda.Function(this, 'LambdaFunction', {
220+
const lambdaHandler = new lambda.Function(this, 'LambdaFunction', {
221221
runtime: lambda.Runtime.PYTHON_3_12,
222222
code: lambda.Code.fromInline('# dummy func'),
223223
handler: 'index.handler',
224224
});
225225

226226
repo.onEvent('OnEventTargetLambda', {
227-
target: {
228-
bind: () => ({ arn: lambdaFunction.functionArn, id: 'OnEventTargetLambda' }),
229-
},
227+
target: new LambdaFunction(lambdaHandler),
230228
});
231229
```

0 commit comments

Comments
 (0)