Skip to content

Commit dfa09d1

Browse files
vinayak-kukrejavinayak-kukreja
authored
fix(WAFv2): add patch to revert struct names (#24651)
This PR is reverting the property type names from pattern `FooAction` to `Foo` for `WAFv2` resource. This change was introduced as part of a [CFNSpec merge](affe040#diff-827a2fd012e049c7ccedffa0360c12e7d967a173f36b8150de73ef6adc42ee4cL175-L357) and would be breaking existing customers if they were using previous property names. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 1ba85fe commit dfa09d1

File tree

2 files changed

+111
-0
lines changed

2 files changed

+111
-0
lines changed

‎packages/@aws-cdk/cfnspec/spec-source/specification/000_cfn/500_Revert_To_Json_Types_patch.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -904,6 +904,15 @@
904904
"path": "/Properties/Captcha/PrimitiveType",
905905
"value": "Json"
906906
},
907+
{
908+
"op": "remove",
909+
"path": "/Properties/Challenge/Type"
910+
},
911+
{
912+
"op": "add",
913+
"path": "/Properties/Challenge/PrimitiveType",
914+
"value": "Json"
915+
},
907916
{
908917
"op": "remove",
909918
"path": "/Properties/Count/Type"

‎packages/@aws-cdk/cfnspec/spec-source/specification/000_cfn/500_WAFv2_RuleGroup_Rename_Properties_patch.json

Lines changed: 102 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
1+
{
2+
"patch": {
3+
"description": "Reverting property type names from FooAction to Foo, which were introduced as part of this PR: https://github.com/aws/aws-cdk/pull/23984",
4+
"operations": [
5+
{
6+
"op": "remove",
7+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.AllowAction"
8+
},
9+
{
10+
"op": "add",
11+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Allow",
12+
"value": {
13+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-allowaction.html",
14+
"Properties": {
15+
"CustomRequestHandling": {
16+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-allowaction.html#cfn-wafv2-rulegroup-allowaction-customrequesthandling",
17+
"Required": false,
18+
"Type": "CustomRequestHandling",
19+
"UpdateType": "Mutable"
20+
}
21+
}
22+
}
23+
},
24+
{
25+
"op": "remove",
26+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.BlockAction"
27+
},
28+
{
29+
"op": "add",
30+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Block",
31+
"value": {
32+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-blockaction.html",
33+
"Properties": {
34+
"CustomResponse": {
35+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-blockaction.html#cfn-wafv2-rulegroup-blockaction-customresponse",
36+
"Required": false,
37+
"Type": "CustomResponse",
38+
"UpdateType": "Mutable"
39+
}
40+
}
41+
}
42+
},
43+
{
44+
"op": "remove",
45+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.CaptchaAction"
46+
},
47+
{
48+
"op": "add",
49+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Captcha",
50+
"value": {
51+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-captchaaction.html",
52+
"Properties": {
53+
"CustomRequestHandling": {
54+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-captchaaction.html#cfn-wafv2-rulegroup-captchaaction-customrequesthandling",
55+
"Required": false,
56+
"Type": "CustomRequestHandling",
57+
"UpdateType": "Mutable"
58+
}
59+
}
60+
}
61+
},
62+
{
63+
"op": "remove",
64+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.ChallengeAction"
65+
},
66+
{
67+
"op": "add",
68+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Challenge",
69+
"value": {
70+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-challengeaction.html",
71+
"Properties": {
72+
"CustomRequestHandling": {
73+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-challengeaction.html#cfn-wafv2-rulegroup-challengeaction-customrequesthandling",
74+
"Required": false,
75+
"Type": "CustomRequestHandling",
76+
"UpdateType": "Mutable"
77+
}
78+
}
79+
}
80+
},
81+
{
82+
"op": "remove",
83+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.CountAction"
84+
},
85+
{
86+
"op": "add",
87+
"path": "/PropertyTypes/AWS::WAFv2::RuleGroup.Count",
88+
"value": {
89+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-countaction.html",
90+
"Properties": {
91+
"CustomRequestHandling": {
92+
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-wafv2-rulegroup-countaction.html#cfn-wafv2-rulegroup-countaction-customrequesthandling",
93+
"Required": false,
94+
"Type": "CustomRequestHandling",
95+
"UpdateType": "Mutable"
96+
}
97+
}
98+
}
99+
}
100+
]
101+
}
102+
}

0 commit comments

Comments
 (0)