Skip to content

Commit cbf852d

Browse files
committed
Change timestamp to number
1 parent 89b108b commit cbf852d

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

packages/@aws-cdk/aws-pipes-sources-alpha/lib/kinesis.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,14 @@ export interface KinesisSourceParameters {
8787

8888
/**
8989
* With StartingPosition set to AT_TIMESTAMP, the time from which to start reading, in Unix time seconds.
90+
*
91+
* @example
92+
* 1711576897
9093
*
9194
* @see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-pipes-pipe-pipesourcekinesisstreamparameters.html#cfn-pipes-pipe-pipesourcekinesisstreamparameters-startingpositiontimestamp
9295
* @default - no starting position timestamp
9396
*/
94-
readonly startingPositionTimestamp?: string;
97+
readonly startingPositionTimestamp?: number;
9598
}
9699

97100
/**
@@ -168,7 +171,7 @@ export class KinesisSource implements ISource {
168171
onPartialBatchItemFailure: this.sourceParameters.onPartialBatchItemFailure,
169172
parallelizationFactor: this.sourceParameters.parallelizationFactor,
170173
startingPosition: this.sourceParameters.startingPosition,
171-
startingPositionTimestamp: this.sourceParameters.startingPositionTimestamp,
174+
startingPositionTimestamp: this.sourceParameters.startingPositionTimestamp?.toString(),
172175
},
173176
},
174177
};

packages/@aws-cdk/aws-pipes-sources-alpha/test/integ.kinesis.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ const sourceUnderTest = new KinesisSource(sourceKinesisStream, {
3636
onPartialBatchItemFailure: OnPartialBatchItemFailure.AUTOMATIC_BISECT,
3737
parallelizationFactor: 1,
3838
startingPosition: KinesisStartingPosition.LATEST,
39+
startingPositionTimestamp: 1711576897,
3940
});
4041

4142
new Pipe(stack, 'Pipe', {

packages/@aws-cdk/aws-pipes-sources-alpha/test/kinesis.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ describe('kinesis source', () => {
5656
onPartialBatchItemFailure: OnPartialBatchItemFailure.AUTOMATIC_BISECT,
5757
parallelizationFactor: 10,
5858
startingPosition: KinesisStartingPosition.LATEST,
59-
startingPositionTimestamp: 'MyTimestamp',
59+
startingPositionTimestamp: 1711576897,
6060
});
6161

6262
new Pipe(stack, 'MyPipe', {
@@ -87,7 +87,7 @@ describe('kinesis source', () => {
8787
OnPartialBatchItemFailure: 'AUTOMATIC_BISECT',
8888
ParallelizationFactor: 10,
8989
StartingPosition: 'LATEST',
90-
StartingPositionTimestamp: 'MyTimestamp',
90+
StartingPositionTimestamp: '1711576897',
9191
},
9292
},
9393
});
@@ -108,7 +108,7 @@ describe('kinesis source', () => {
108108
onPartialBatchItemFailure: OnPartialBatchItemFailure.AUTOMATIC_BISECT,
109109
parallelizationFactor: 10,
110110
startingPosition: KinesisStartingPosition.LATEST,
111-
startingPositionTimestamp: 'MyTimestamp',
111+
startingPositionTimestamp: 1711576897,
112112
});
113113

114114
new Pipe(stack, 'MyPipe', {
@@ -144,7 +144,7 @@ describe('kinesis source', () => {
144144
OnPartialBatchItemFailure: 'AUTOMATIC_BISECT',
145145
ParallelizationFactor: 10,
146146
StartingPosition: 'LATEST',
147-
StartingPositionTimestamp: 'MyTimestamp',
147+
StartingPositionTimestamp: '1711576897',
148148
},
149149
},
150150
});

0 commit comments

Comments
 (0)