chore: enforce consistent-type-imports everywhere (#229)

We were already enforcing this rule in `toolkit-lib`. Let's enforce it
everywhere.

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>

Author: mrgrain

.eslintrc.json

@@ -729,7 +729,6 @@ tmpToolkitHelpers.package.addField('exports', {
 
 tmpToolkitHelpers.eslint?.addRules({
   '@cdklabs/no-throw-default-error': 'error',
-  '@typescript-eslint/consistent-type-imports': 'error',
 });
 
 tmpToolkitHelpers.gitignore.addPatterns('test/**/*.map');
@@ -1218,7 +1217,6 @@ new S3DocsPublishing(toolkitLib, {
 // Eslint rules
 toolkitLib.eslint?.addRules({
   '@cdklabs/no-throw-default-error': 'error',
-  '@typescript-eslint/consistent-type-imports': 'error',
   'import/no-restricted-paths': ['error', {
     zones: [{
       target: './',

.projenrc.ts

@@ -1,6 +1,7 @@
 import { makeExecutable, shell } from './os';
-import { CDKBuildOptions, CompilerOverrides, currentPackageJson, packageCompiler } from './package-info';
-import { Timers } from './timer';
+import type { CDKBuildOptions, CompilerOverrides } from './package-info';
+import { currentPackageJson, packageCompiler } from './package-info';
+import type { Timers } from './timer';
 
 /**
  * Run the compiler on the current package

packages/@aws-cdk/cdk-build-tools/.eslintrc.json

@@ -2,8 +2,8 @@ import * as path from 'path';
 import * as process from 'process';
 import * as fs from 'fs-extra';
 import { shell, escape } from './os';
-import { CDKBuildOptions, CompilerOverrides } from './package-info';
-import { Timers } from './timer';
+import type { CDKBuildOptions, CompilerOverrides } from './package-info';
+import type { Timers } from './timer';
 
 export async function lintCurrentPackage(
   options: CDKBuildOptions,

packages/@aws-cdk/cdk-build-tools/lib/compile.ts

@@ -1,5 +1,6 @@
-import { ChildProcess } from 'child_process';
-import { DefaultCdkOptions, DeployOptions, DestroyOptions, SynthOptions, ListOptions, StackActivityProgress, HotswapMode } from './commands';
+import type { ChildProcess } from 'child_process';
+import type { DefaultCdkOptions, DeployOptions, DestroyOptions, SynthOptions, ListOptions } from './commands';
+import { StackActivityProgress, HotswapMode } from './commands';
 import { exec, watch } from './utils';
 
 /**

packages/@aws-cdk/cdk-build-tools/lib/lint.ts

@@ -1,4 +1,4 @@
-import { DefaultCdkOptions, RequireApproval } from './common';
+import type { DefaultCdkOptions, RequireApproval } from './common';
 
 /**
  * Options to use with cdk deploy

packages/@aws-cdk/cdk-cli-wrapper/.eslintrc.json

@@ -1,4 +1,4 @@
-import { DefaultCdkOptions } from './common';
+import type { DefaultCdkOptions } from './common';
 
 /**
  * Options to use with cdk destroy

packages/@aws-cdk/cdk-cli-wrapper/lib/cdk-wrapper.ts

@@ -1,4 +1,4 @@
-import { DefaultCdkOptions } from './common';
+import type { DefaultCdkOptions } from './common';
 
 /**
  * Options for cdk list