Skip to content

Commit 8c793f2

Browse files
add pod/namespace to cni log msgs
1 parent 6d1938e commit 8c793f2

1 file changed

Lines changed: 12 additions & 6 deletions

File tree

plugins/routed-eni/cni.go

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,13 @@ func add(args *skel.CmdArgs, cniTypes typeswrapper.CNITYPES, grpcClient grpcwrap
124124
}
125125

126126
if !r.Success {
127-
log.Errorf("Failed to assign an IP address to container")
127+
log.Errorf("Failed to assign an IP address to pod %s, namespace %s", string(k8sArgs.K8S_POD_NAME), string(k8sArgs.K8S_POD_NAMESPACE))
128128
return fmt.Errorf("add cmd: failed to assign an IP address to container")
129129
}
130130

131-
log.Debugf("Received add network response: %s, Table %d", r.IPv4Addr, r.DeviceNumber)
131+
log.Infof("Received add network response for pod %s namespace %s: %s, table %d ",
132+
string(k8sArgs.K8S_POD_NAME), string(k8sArgs.K8S_POD_NAMESPACE),
133+
r.IPv4Addr, r.DeviceNumber)
132134

133135
addr := &net.IPNet{
134136
IP: net.ParseIP(r.IPv4Addr),
@@ -147,7 +149,8 @@ func add(args *skel.CmdArgs, cniTypes typeswrapper.CNITYPES, grpcClient grpcwrap
147149
err = driverClient.SetupNS(hostVethName, args.IfName, args.Netns, addr, int(r.DeviceNumber))
148150

149151
if err != nil {
150-
log.Errorf("Failed SetupPodNetwork: %v", err)
152+
log.Errorf("Failed SetupPodNetwork for pod %s namespace %s: %v",
153+
string(k8sArgs.K8S_POD_NAME), string(k8sArgs.K8S_POD_NAMESPACE), err)
151154
return errors.Wrap(err, "add command: failed to setup network")
152155
}
153156

@@ -203,12 +206,14 @@ func del(args *skel.CmdArgs, cniTypes typeswrapper.CNITYPES, grpcClient grpcwrap
203206
IPv4Addr: k8sArgs.IP.String()})
204207

205208
if err != nil {
206-
log.Errorf("Error received from backend server for del network request: %v", err)
209+
log.Errorf("Error received from backend server for del network request for pod %s namespace %s: %v",
210+
string(k8sArgs.K8S_POD_NAME), string(k8sArgs.K8S_POD_NAMESPACE), err)
207211
return err
208212
}
209213

210214
if !r.Success {
211-
log.Errorf("Failed to process delete request %v", err)
215+
log.Errorf("Failed to process delete request for pod %s namespace %s: %v",
216+
string(k8sArgs.K8S_POD_NAME), string(k8sArgs.K8S_POD_NAMESPACE), err)
212217
return errors.Wrap(err, "del cmd: failed to process delete request")
213218
}
214219

@@ -220,7 +225,8 @@ func del(args *skel.CmdArgs, cniTypes typeswrapper.CNITYPES, grpcClient grpcwrap
220225
err = driverClient.TeardownNS(addr, int(r.DeviceNumber))
221226

222227
if err != nil {
223-
log.Errorf("Failed on TeardownPodNetwork %v", err)
228+
log.Errorf("Failed on TeardownPodNetwork for pod %s namespace %s: %v",
229+
string(k8sArgs.K8S_POD_NAME), string(k8sArgs.K8S_POD_NAMESPACE), err)
224230
return err
225231
}
226232
return nil

0 commit comments

Comments
 (0)