chore(build): fix build warnings for Dynamic Actor Isolation feature (#4005)

* initial commit

* another commit

* unit test fix

* fix: add @unchecked Sendable annotations for warnings

* chore: fix swiftlint errors

* chore: fix build error

* chore: fix failing test

* chore: fix failing test

* chore: revert Package.swift

---------

Co-authored-by: Abhash Kumar Singh <[email protected]>

Author: harsh62

Amplify/Amplify.swift

@@ -20,44 +20,83 @@ import Foundation
 /// available at initialization.
 ///
 /// - Tag: Amplify
-public class Amplify {
+public class Amplify: @unchecked Sendable {
 
     /// If `true`, `configure()` has already been invoked, and subsequent calls to `configure` will throw a
     /// ConfigurationError.amplifyAlreadyConfigured error.
     ///
     /// - Tag: Amplify.isConfigured
-    static var isConfigured = false
+    private static let isConfiguredAtomic = AtomicValue<Bool>(initialValue: false)
+    static var isConfigured: Bool {
+        get { isConfiguredAtomic.get() }
+        set { isConfiguredAtomic.set(newValue) }
+    }
 
     // Storage for the categories themselves, which will be instantiated during configuration, and cleared during reset.
-    // It is not supported to mutate these category properties. They are `var` to support the `reset()` method for
-    // ease of testing.
+    // All category properties are protected with AtomicValue for thread safety.
 
     /// - Tag: Amplify.Analytics
-    public static internal(set) var Analytics = AnalyticsCategory()
+    private static let analyticsAtomic = AtomicValue<AnalyticsCategory>(initialValue: AnalyticsCategory())
+    public static internal(set) var Analytics: AnalyticsCategory {
+        get { analyticsAtomic.get() }
+        set { analyticsAtomic.set(newValue) }
+    }
 
     /// - Tag: Amplify.API
-    public static internal(set) var API: APICategory = APICategory()
+    private static let apiAtomic = AtomicValue<APICategory>(initialValue: APICategory())
+    public static internal(set) var API: APICategory {
+        get { apiAtomic.get() }
+        set { apiAtomic.set(newValue) }
+    }
 
     /// - Tag: Amplify.Auth
-    public static internal(set) var Auth = AuthCategory()
+    private static let authAtomic = AtomicValue<AuthCategory>(initialValue: AuthCategory())
+    public static internal(set) var Auth: AuthCategory {
+        get { authAtomic.get() }
+        set { authAtomic.set(newValue) }
+    }
 
     /// - Tag: Amplify.DataStore
-    public static internal(set) var DataStore = DataStoreCategory()
+    private static let dataStoreAtomic = AtomicValue<DataStoreCategory>(initialValue: DataStoreCategory())
+    public static internal(set) var DataStore: DataStoreCategory {
+        get { dataStoreAtomic.get() }
+        set { dataStoreAtomic.set(newValue) }
+    }
 
     /// - Tag: Amplify.Geo
-    public static internal(set) var Geo = GeoCategory()
+    private static let geoAtomic = AtomicValue<GeoCategory>(initialValue: GeoCategory())
+    public static internal(set) var Geo: GeoCategory {
+        get { geoAtomic.get() }
+        set { geoAtomic.set(newValue) }
+    }
 
     /// - Tag: Amplify.Hub
-    public static internal(set) var Hub = HubCategory()
+    private static let hubAtomic = AtomicValue<HubCategory>(initialValue: HubCategory())
+    public static internal(set) var Hub: HubCategory {
+        get { hubAtomic.get() }
+        set { hubAtomic.set(newValue) }
+    }
 
     /// - Tag: Amplify.Notifications
-    public static internal(set) var Notifications = NotificationsCategory()
+    private static let notificationsAtomic = AtomicValue<NotificationsCategory>(initialValue: NotificationsCategory())
+    public static internal(set) var Notifications: NotificationsCategory {
+        get { notificationsAtomic.get() }
+        set { notificationsAtomic.set(newValue) }
+    }
 
     /// - Tag: Amplify.Predictions
-    public static internal(set) var Predictions = PredictionsCategory()
+    private static let predictionsAtomic = AtomicValue<PredictionsCategory>(initialValue: PredictionsCategory())
+    public static internal(set) var Predictions: PredictionsCategory {
+        get { predictionsAtomic.get() }
+        set { predictionsAtomic.set(newValue) }
+    }
 
     /// - Tag: Amplify.Storage
-    public static internal(set) var Storage = StorageCategory()
+    private static let storageAtomic = AtomicValue<StorageCategory>(initialValue: StorageCategory())
+    public static internal(set) var Storage: StorageCategory {
+        get { storageAtomic.get() }
+        set { storageAtomic.set(newValue) }
+    }
 
     /// Special case category. We protect this with an AtomicValue because it is used by reset()
     /// methods during setup & teardown of tests

Amplify/Categories/API/Operation/GraphQLOperation.swift

@@ -10,15 +10,15 @@ open class GraphQLOperation<R: Decodable>: AmplifyOperation<
     GraphQLOperationRequest<R>,
     GraphQLResponse<R>,
     APIError
-> { }
+>, @unchecked Sendable { }
 
 /// GraphQL Subscription Operation
 open class GraphQLSubscriptionOperation<R: Decodable>: AmplifyInProcessReportingOperation<
     GraphQLOperationRequest<R>,
     GraphQLSubscriptionEvent<R>,
     Void,
     APIError
-> { }
+>, @unchecked Sendable { }
 
 public extension HubPayload.EventName.API {
     /// eventName for HubPayloads emitted by this operation

Amplify/Categories/API/Response/SubscriptionEvent.swift

@@ -6,7 +6,7 @@
 //
 
 /// Event for subscription
-public enum GraphQLSubscriptionEvent<T: Decodable> {
+public enum GraphQLSubscriptionEvent<T> where T: Decodable, T: Sendable {
     /// The subscription's connection state has changed.
     case connection(SubscriptionConnectionState)
 

Amplify/Categories/Auth/AuthCategory+UserBehavior.swift

@@ -9,7 +9,10 @@ import Foundation
 
 extension AuthCategory: AuthCategoryUserBehavior {
 
-    public func getCurrentUser() async throws -> AuthUser {
+    /// Retrieve the current logged in user
+    ///
+    /// - Returns: Current logged in user
+    public func getCurrentUser() async throws -> any AuthUser {
         try await plugin.getCurrentUser()
     }
 

Amplify/Categories/Auth/AuthCategoryUserBehavior.swift

@@ -9,9 +9,10 @@ import Foundation
 
 public protocol AuthCategoryUserBehavior: AnyObject {
 
-    /// Returns the currently logged in user.
+    /// Retrieve the current logged in user
     ///
-    func getCurrentUser() async throws -> AuthUser
+    /// - Returns: Current logged in user
+    func getCurrentUser() async throws -> any AuthUser
 
     /// Fetch user attributes for the current user.
     ///

Amplify/Categories/Auth/Models/AuthCodeDeliveryDetails.swift

@@ -26,3 +26,5 @@ public struct AuthCodeDeliveryDetails {
 }
 
 extension AuthCodeDeliveryDetails: Equatable {}
+
+extension AuthCodeDeliveryDetails: Sendable {}

Amplify/Categories/Auth/Models/AuthDevice.swift

@@ -8,7 +8,7 @@
 import Foundation
 
 /// Device used by the user to sign in
-public protocol AuthDevice {
+public protocol AuthDevice: Sendable {
 
     /// Device id
     var id: String { get }

Amplify/Categories/Auth/Models/AuthFactorType.swift

@@ -25,3 +25,5 @@ public enum AuthFactorType: String {
     case webAuthn
 #endif
 }
+
+extension AuthFactorType: Sendable { }

Amplify/Categories/Auth/Models/AuthSession.swift

@@ -8,7 +8,7 @@
 import Foundation
 
 /// Defines the auth session behavior
-public protocol AuthSession {
+public protocol AuthSession: Sendable {
 
     /// True if the current user has signed in
     ///

Amplify/Categories/Auth/Models/AuthSignInStep.swift

@@ -77,3 +77,5 @@ public enum AuthSignInStep {
 }
 
 extension AuthSignInStep: Equatable { }
+
+extension AuthSignInStep: Sendable { }