Require Node.js 8

sindresorhus · sindresorhus · commit 809f8c2153bc · 2019-05-23T12:54:14.000+07:00
diff --git a/.travis.yml b/.travis.yml
@@ -1,8 +1,7 @@
 language: node_js
 node_js:
-  - 11
+  - 12
   - 10
   - 8
-  - 6
 before_install: npm install --global npm
 after_success: npx codecov --file=./coverage/lcov.info
diff --git a/create-ava-rule.js b/create-ava-rule.js
@@ -60,7 +60,7 @@ function getTestModifierNames(node) {
 
 module.exports = () => {
 	let isTestFile = false;
-	let currentTestNode = null;
+	let currentTestNode;
 
 	/* eslint quote-props: [2, "as-needed"] */
 	const predefinedRules = {
@@ -83,7 +83,7 @@ module.exports = () => {
 		'CallExpression:exit': node => {
 			if (currentTestNode === node) {
 				// Leaving test function
-				currentTestNode = null;
+				currentTestNode = undefined;
 			}
 		},
 		'Program:exit': () => {
@@ -92,7 +92,7 @@ module.exports = () => {
 	};
 
 	return {
-		hasTestModifier: mod => getTestModifierNames(currentTestNode).indexOf(mod) >= 0,
+		hasTestModifier: mod => getTestModifierNames(currentTestNode).includes(mod),
 		hasNoHookModifier: () => {
 			const modifiers = getTestModifierNames(currentTestNode);
 			return !modifiers.includes('before') &&
diff --git a/docs/rules/no-only-test.md b/docs/rules/no-only-test.md
@@ -4,6 +4,8 @@ Translations: [Français](https://github.com/avajs/ava-docs/blob/master/fr_FR/re
 
 It's easy to run only one test with `test.only()` and then forget about it. It's visible in the results, but still easily missed. Forgetting to remove `.only`, means only this one test in the whole file will run, and if not caught, can let serious bugs slip into your codebase.
 
+This rule is fixable.
+
 
 ## Fail
 
diff --git a/docs/rules/no-skip-test.md b/docs/rules/no-skip-test.md
@@ -4,6 +4,8 @@ Translations: [Français](https://github.com/avajs/ava-docs/blob/master/fr_FR/re
 
 It's easy to make a test skipped with test.skip() and then forget about it. It's visible in the results, but still easily missed.
 
+This rule is fixable.
+
 
 ## Fail
 
diff --git a/docs/rules/use-t-well.md b/docs/rules/use-t-well.md
@@ -4,7 +4,7 @@ Translations: [Français](https://github.com/avajs/ava-docs/blob/master/fr_FR/re
 
 Prevent the use of unknown assertion methods and the access to members other than the assertion methods and `context`, as well as some known misuses of `t`.
 
-This rule is partly automatically fixable. It will replace misspelled `falsey` with `falsy`.
+This rule is partly fixable. It will replace misspelled `falsey` with `falsy`.
 
 
 ## Fail
diff --git a/index.js b/index.js
@@ -40,10 +40,7 @@ module.exports = {
 				'ava/prefer-async-await': 'error',
 				'ava/prefer-power-assert': 'off',
 				'ava/test-ended': 'error',
-				'ava/test-title': [
-					'error',
-					'if-multiple'
-				],
+				'ava/test-title': 'error',
 				'ava/use-t-well': 'error',
 				'ava/use-t': 'error',
 				'ava/use-test': 'error',
diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
 	"license": "MIT",
 	"repository": "avajs/eslint-plugin-ava",
 	"engines": {
-		"node": ">=6"
+		"node": ">=8"
 	},
 	"scripts": {
 		"test": "xo && nyc ava"
@@ -29,26 +29,26 @@
 		"mocha"
 	],
 	"dependencies": {
-		"arrify": "^1.0.1",
+		"arrify": "^2.0.1",
 		"deep-strict-equal": "^0.2.0",
 		"enhance-visitors": "^1.0.0",
-		"esm": "^3.0.84",
+		"esm": "^3.2.25",
 		"espree": "^5.0.0",
 		"espurify": "^2.0.0",
 		"import-modules": "^1.1.0",
-		"is-plain-object": "^2.0.4",
-		"multimatch": "^3.0.0",
-		"pkg-up": "^2.0.0"
+		"is-plain-object": "^3.0.0",
+		"multimatch": "^4.0.0",
+		"pkg-up": "^3.1.0"
 	},
 	"devDependencies": {
 		"ava": "^1.0.1",
 		"babel-eslint": "^10.0.1",
-		"codecov": "^3.2.0",
+		"codecov": "^3.5.0",
 		"eslint": "^5.12.0",
 		"eslint-ava-rule-tester": "^3.0.0",
-		"eslint-plugin-eslint-plugin": "^2.0.1",
+		"eslint-plugin-eslint-plugin": "2.1.0",
 		"js-combinatorics": "^0.5.4",
-		"nyc": "^13.1.0",
+		"nyc": "^14.1.1",
 		"pify": "^4.0.1",
 		"xo": "^0.24.0"
 	},
diff --git a/readme.md b/readme.md
@@ -58,10 +58,7 @@ Configure it in `package.json`.
 			"ava/prefer-async-await": "error",
 			"ava/prefer-power-assert": "off",
 			"ava/test-ended": "error",
-			"ava/test-title": [
-				"error",
-				"if-multiple"
-			],
+			"ava/test-title": "error",
 			"ava/use-t-well": "error",
 			"ava/use-t": "error",
 			"ava/use-test": "error",
diff --git a/rules/max-asserts.js b/rules/max-asserts.js
@@ -9,7 +9,7 @@ const create = context => {
 	const ava = createAvaRule();
 	const maxAssertions = context.options[0] || 5;
 	let assertionCount = 0;
-	let nodeToReport = null;
+	let nodeToReport;
 
 	return ava.merge({
 		CallExpression: visitIf([
@@ -50,7 +50,7 @@ const create = context => {
 			}
 
 			assertionCount = 0;
-			nodeToReport = null;
+			nodeToReport = undefined;
 		})
 	});
 };
diff --git a/rules/no-async-fn-without-await.js b/rules/no-async-fn-without-await.js
@@ -5,8 +5,8 @@ const util = require('../util');
 
 const create = context => {
 	const ava = createAvaRule();
-	let asyncTest = null;
 	let testUsed = false;
+	let asyncTest;
 
 	const registerUseOfAwait = () => {
 		if (asyncTest) {
@@ -22,8 +22,7 @@ const create = context => {
 			ava.isTestNode
 		])(node => {
 			asyncTest = (isAsync(node.arguments[0]) && node.arguments[0]) ||
-				(isAsync(node.arguments[1]) && node.arguments[1]) ||
-				null;
+				(isAsync(node.arguments[1]) && node.arguments[1]);
 		}),
 		AwaitExpression: registerUseOfAwait,
 		YieldExpression: registerUseOfAwait,
@@ -39,11 +38,11 @@ const create = context => {
 						start: asyncTest.loc.start,
 						end: asyncTest.loc.start + 5
 					},
-					message: 'Function was declared as `async` but doesn\'t use `await`'
+					message: 'Function was declared as `async` but doesn\'t use `await`.'
 				});
 			}
 
-			asyncTest = null;
+			asyncTest = undefined;
 			testUsed = false;
 		})
 	});
diff --git a/rules/no-identical-title.js b/rules/no-identical-title.js
@@ -7,13 +7,11 @@ const createAvaRule = require('../create-ava-rule');
 
 const purify = node => node && espurify(node);
 
-let isStatic = null;
-
 const isStaticTemplateLiteral = node => node.expressions.every(isStatic);
 
-isStatic = node => node.type === 'Literal' ||
-		(node.type === 'TemplateLiteral' && isStaticTemplateLiteral(node)) ||
-		(node.type === 'BinaryExpression' && isStatic(node.left) && isStatic(node.right));
+const isStatic = node => node.type === 'Literal' ||
+	(node.type === 'TemplateLiteral' && isStaticTemplateLiteral(node)) ||
+	(node.type === 'BinaryExpression' && isStatic(node.left) && isStatic(node.right));
 
 function isTitleUsed(usedTitleNodes, titleNode) {
 	const purifiedNode = purify(titleNode);
@@ -33,8 +31,8 @@ const create = context => {
 			const args = node.arguments;
 			const titleNode = args.length > 1 || ava.hasTestModifier('todo') ? args[0] : undefined;
 
-			// Don't flag computed titles or anonymous tests (anon tests covered in the if-multiple rule)
-			if (titleNode === undefined || !isStatic(titleNode)) {
+			// Don't flag computed titles
+			if (!isStatic(titleNode)) {
 				return;
 			}
 
diff --git a/rules/no-ignored-test-files.js b/rules/no-ignored-test-files.js
@@ -22,8 +22,6 @@ function isIgnored(rootDir, files, filepath) {
 	if (multimatch([relativeFilePath], files).length === 0) {
 		return `Test file is ignored because it is not in \`${files.join(' ')}\`.`;
 	}
-
-	return null;
 }
 
 function getPackageInfo() {
diff --git a/rules/no-import-test-files.js b/rules/no-import-test-files.js
@@ -41,7 +41,7 @@ function createImportValidator(context, files, projectInfo, filename) {
 		if (isImportingTestFile) {
 			context.report({
 				node,
-				message: 'Test files should not be imported'
+				message: 'Test files should not be imported.'
 			});
 		}
 	};
diff --git a/rules/no-statement-after-end.js b/rules/no-statement-after-end.js
@@ -18,7 +18,8 @@ const create = context => {
 	const ava = createAvaRule();
 	const segmentInfoMap = new Map();
 	const segmentInfoStack = [];
-	let currentSegmentInfo = null;
+
+	let currentSegmentInfo;
 
 	function segmentStart(segment) {
 		// A new CodePathSegment has started, create an "info" object to track this segments state.
diff --git a/rules/use-t-well.js b/rules/use-t-well.js
@@ -101,7 +101,7 @@ const create = context => {
 					context.report({
 						node,
 						message: 'Misspelled `falsy` as `falsey`.',
-						fix: fixer => fixer.replaceTextRange(node.property.range, 'falsy')
+						fix: fixer => fixer.replaceText(node.property, 'falsy')
 					});
 				} else if (stats.method.length > 1) {
 					context.report({
diff --git a/rules/use-true-false.js b/rules/use-true-false.js
@@ -36,12 +36,12 @@ const knownBooleanSignatures = [
 	'Reflect.isExtensible()'
 ].map(signature => espurify(espree.parse(signature).body[0].expression.callee));
 
-function matchesKnownBooleanExpression(arg) {
-	if (arg.type !== 'CallExpression') {
+function matchesKnownBooleanExpression(argument) {
+	if (argument.type !== 'CallExpression') {
 		return false;
 	}
 
-	const callee = espurify(arg.callee);
+	const callee = espurify(argument.callee);
 
 	return knownBooleanSignatures.some(signature => deepStrictEqual(callee, signature));
 }
@@ -59,13 +59,13 @@ const create = context => {
 				(node.callee.property.name === 'truthy' || node.callee.property.name === 'falsy') &&
 				node.callee.object.name === 't'
 			) {
-				const arg = node.arguments[0];
+				const argument = node.arguments[0];
 
-				if (arg &&
-					((arg.type === 'BinaryExpression' && booleanBinaryOperators.includes(arg.operator)) ||
-					(arg.type === 'UnaryExpression' && arg.operator === '!') ||
-					(arg.type === 'Literal' && arg.value === Boolean(arg.value)) ||
-					(matchesKnownBooleanExpression(arg)))
+				if (argument &&
+					((argument.type === 'BinaryExpression' && booleanBinaryOperators.includes(argument.operator)) ||
+					(argument.type === 'UnaryExpression' && argument.operator === '!') ||
+					(argument.type === 'Literal' && argument.value === Boolean(argument.value)) ||
+					(matchesKnownBooleanExpression(argument)))
 				) {
 					if (node.callee.property.name === 'falsy') {
 						context.report({
diff --git a/test/no-async-fn-without-await.js b/test/no-async-fn-without-await.js
@@ -3,7 +3,7 @@ import avaRuleTester from 'eslint-ava-rule-tester';
 import rule from '../rules/no-async-fn-without-await';
 
 const ruleId = 'no-async-fn-without-await';
-const message = 'Function was declared as `async` but doesn\'t use `await`';
+const message = 'Function was declared as `async` but doesn\'t use `await`.';
 const header = 'const test = require(\'ava\');\n';
 
 const ruleTesterOptions = [
diff --git a/test/no-identical-title.js b/test/no-identical-title.js
@@ -16,7 +16,6 @@ const header = 'const test = require(\'ava\');\n';
 ruleTester.run('no-identical-title', rule, {
 	valid: [
 		header + 'test("my test name", t => {});',
-		header + 'test("a", t => {}); test(t => {});',
 		header + 'test("a", t => {}); test("b", t => {});',
 		header + 'test("a", t => {}); test.cb("b", t => {});',
 		header + 'test.todo("a"); test.todo("b");',
@@ -31,19 +30,10 @@ ruleTester.run('no-identical-title', rule, {
 		header + 'test.beforeEach(t => {}); test.beforeEach(t => {});',
 		header + 'test.afterEach(t => {}); test.afterEach(t => {});',
 		header + 'test.cb.before(t => {}); test.before.cb(t => {});',
-		// Multiple anonymous tests covered by the if-multiple rule
-		header + 'test(t => {}); test(t => {});',
-		header + 'test(t => {}); test.cb(t => {});',
 		// Macros
 		` ${header}
 			const macro = (t, value) => { t.true(value); };
 
-			test(macro, true);
-			test(macro, false);
-		`,
-		` ${header}
-			const macro = (t, value) => { t.true(value); };
-
 			test('should work', macro, true);
 			test('should fail', macro, false);
 		`,
diff --git a/test/no-import-test-files.js b/test/no-import-test-files.js
@@ -23,6 +23,12 @@ util.getAvaConfig = () => ({
 	]
 });
 
+const errors = [
+	{
+		message: 'Test files should not be imported.'
+	}
+];
+
 ruleTester.run('no-import-test-files', rule, {
 	valid: [
 		'import test from \'ava\';',
@@ -41,17 +47,17 @@ ruleTester.run('no-import-test-files', rule, {
 		{
 			code: 'const test = require(\'./foo.test.js\');',
 			filename: toPath('lib/foo.js'),
-			errors: [{message: 'Test files should not be imported'}]
+			errors
 		},
 		{
 			code: 'import test from \'./foo.test.js\';',
 			filename: toPath('lib/foo.js'),
-			errors: [{message: 'Test files should not be imported'}]
+			errors
 		},
 		{
 			code: 'import test from \'./bar.js\';',
 			filename: toPath('test/foo.js'),
-			errors: [{message: 'Test files should not be imported'}]
+			errors
 		}
 	]
 });
diff --git a/test/use-t-well.js b/test/use-t-well.js
@@ -12,7 +12,7 @@ const ruleError = {ruleId: 'use-t-well'};
 const header = 'const test = require(\'ava\');\n';
 
 function error(message) {
-	return Object.assign({}, ruleError, {message});
+	return {...ruleError, message};
 }
 
 function testCase(contents, prependHeader) {
diff --git a/test/util.js b/test/util.js
diff --git a/util.js b/util.js
