Skip to content

Commit 3e1102a

Browse files
pvdlgnovemberborn
authored andcommitted
Add t.timeout to use-t-well rule
1 parent 1e53817 commit 3e1102a

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

rules/assertion-arguments.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,10 @@ const expectedNbArguments = {
7171
truthy: {
7272
min: 1,
7373
max: 2
74+
},
75+
timeout: {
76+
min: 1,
77+
max: 1
7478
}
7579
};
7680

test/assertion-arguments.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ ruleTester.run('assertion-arguments', rule, {
5454
testCase(false, 't.truthy(\'unicorn\', \'message\');'),
5555
testCase(false, 't.snapshot(value, \'message\');'),
5656
testCase(false, 't.context.plan();'),
57+
testCase(false, 't.timeout(100);'),
5758
testCase(false, 'foo.t.plan();'),
5859
// Shouldn't be triggered since it's not a test file
5960
testCase(false, 't.true(true);', false, false),
@@ -103,6 +104,7 @@ ruleTester.run('assertion-arguments', rule, {
103104
testCase('always', 't.skip.is(\'same\', \'same\', \'message\');'),
104105
testCase('always', 't.is.skip(\'same\', \'same\', \'message\');'),
105106
testCase('always', 't.snapshot(value, \'message\');'),
107+
testCase('always', 't.timeout(100);'),
106108

107109
// Shouldn't be triggered since it's not a test file
108110
testCase('always', 't.true(true);', [], false),
@@ -131,6 +133,7 @@ ruleTester.run('assertion-arguments', rule, {
131133
testCase('never', 't.skip.is(\'same\', \'same\');'),
132134
testCase('never', 't.is.skip(\'same\', \'same\');'),
133135
testCase('never', 't.snapshot(value);'),
136+
testCase('never', 't.timeout(100);'),
134137
// Shouldn't be triggered since it's not a test file
135138
testCase('never', 't.true(true, \'message\');', [], false),
136139

@@ -177,6 +180,7 @@ ruleTester.run('assertion-arguments', rule, {
177180
testCase(false, 't.skip.is(\'same\');', tooFewError(2)),
178181
testCase(false, 't.is.skip(\'same\');', tooFewError(2)),
179182
testCase(false, 't.snapshot();', tooFewError(1)),
183+
testCase(false, 't.timeout();', tooFewError(1)),
180184

181185
// Too many arguments
182186
testCase(false, 't.plan(1, \'extra argument\');', tooManyError(1)),
@@ -198,6 +202,7 @@ ruleTester.run('assertion-arguments', rule, {
198202
testCase(false, 't.skip.is(\'same\', \'same\', \'message\', \'extra argument\');', tooManyError(3)),
199203
testCase(false, 't.is.skip(\'same\', \'same\', \'message\', \'extra argument\');', tooManyError(3)),
200204
testCase(false, 't.snapshot(value, \'message\', \'extra argument\');', tooManyError(2)),
205+
testCase(false, 't.timeout(1, \'extra argument\');', tooManyError(1)),
201206

202207
testCase('always', 't.pass();', missingError),
203208
testCase('always', 't.fail();', missingError),

test/use-t-well.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ ruleTester.run('use-t-well', rule, {
6464
testCase('a.foo();'),
6565
testCase('t.context.foo(a, a);'),
6666
testCase('foo.t.bar(a, a);'),
67+
testCase('t.timeout(100);'),
6768
// Shouldn't be triggered since it's not a test file
6869
testCase('t.foo(a, a);', false),
6970
testCase('t.foo;', false)

util.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,4 +123,4 @@ const assertionMethodNames = [...assertionMethodsNumArguments.keys()];
123123

124124
exports.assertionMethodsNumArguments = assertionMethodsNumArguments;
125125
exports.assertionMethods = new Set(assertionMethodNames);
126-
exports.executionMethods = new Set(assertionMethodNames.concat(['end', 'plan', 'log']));
126+
exports.executionMethods = new Set(assertionMethodNames.concat(['end', 'plan', 'log', 'timeout']));

0 commit comments

Comments
 (0)