Bound execution context and changed skip #1696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assertions are now bound. Fixes #1592. Assertions are now skipped by calling `.skip()` at the end, e.g. `t.fail.skip()`. This is consistent with the test interface, where `skip()` can only be used at the end of the chain. The private `t._test` value has been removed. Instead a WeakMap is used internally to look up the corresponding Test instance given an ExecutionContext.
Ensure subsequent t.snapshot() calls compare the correct snapshot. Forbid snapshots from being skipped while updating them. Fixes #1425.
See #1425 (comment) though. |
I agree. Way too much of an edge-case to care about. |
sindresorhus
approved these changes
Feb 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.skip()at the end, e.g.t.fail.skip(). This is consistent with the test interface, whereskip()can only be used at the end of the chain.t._testvalue has been removed. Instead a WeakMap is used internally to look up the corresponding Test instance given an ExecutionContext.t.snapshot.skip(). Ensure subsequentt.snapshot()calls compare the correct snapshot. Forbid snapshots from being skipped while updating them. Fixes Skipping a snapshot assertion should not cause the next snapshot assertion to fail #1425.