@atlaspack/types-internal

Remove libgit dependency

Uses git CLI instead of libgit since we can't use it fully due to sparse
checkouts.

Test Plan: yarn test:integration

Reviewers:
marcins, JakeLane, pancaspe87, csowden-atlassian, alshdavid, mattcompiles

Reviewed By:
alshdavid, pancaspe87, mattcompiles, csowden-atlassian, marcins, JakeLane

Pull Request: #589

Fix: Running benchmarks from temp directory (#590)

Author: alshdavid

packages/core/types-internal/package.json

@@ -6,31 +6,34 @@ const rule = require('../../src/rules/no-relative-import');
 
 const filename = __filename;
 
-new RuleTester({
-  parser: require.resolve('@babel/eslint-parser'),
-  parserOptions: {ecmaVersion: 2018, sourceType: 'module'},
-}).run('no-relative-import', rule, {
-  valid: [{code: "import logger from '@atlaspack/logger';", filename}],
-  invalid: [
-    {
-      code: `import Logger from '../../../../core/logger/src/Logger';`,
-      errors: [
-        {
-          message: `Import for monorepo package '@atlaspack/logger' should be absolute.`,
-        },
-      ],
-      filename,
-      output: "import Logger from '@atlaspack/logger/src/Logger';",
-    },
-    {
-      code: `import type { PluginOptions } from '../../../../core/types-internal/src';`,
-      errors: [
-        {
-          message: `Import for monorepo package '@atlaspack/types-internal' should be absolute.`,
-        },
-      ],
-      filename,
-      output: "import type { PluginOptions } from '@atlaspack/types-internal';",
-    },
-  ],
+describe('eslint-rules', () => {
+  new RuleTester({
+    parser: require.resolve('@babel/eslint-parser'),
+    parserOptions: {ecmaVersion: 2018, sourceType: 'module'},
+  }).run('no-relative-import', rule, {
+    valid: [{code: "import logger from '@atlaspack/logger';", filename}],
+    invalid: [
+      {
+        code: `import Logger from '../../../../core/logger/src/Logger';`,
+        errors: [
+          {
+            message: `Import for monorepo package '@atlaspack/logger' should be absolute.`,
+          },
+        ],
+        filename,
+        output: "import Logger from '@atlaspack/logger/src/Logger';",
+      },
+      {
+        code: `import type { PluginOptions } from '../../../../unified/src/types-internal';`,
+        errors: [
+          {
+            message: `Import for monorepo package '@atlaspack/unified' should be absolute.`,
+          },
+        ],
+        filename,
+        output:
+          "import type { PluginOptions } from '@atlaspack/unified/types-internal';",
+      },
+    ],
+  });
 });

packages/core/types-internal/scripts/build-ts.js

@@ -0,0 +1 @@
+export * from '@atlaspack/unified/types-internal';

packages/core/types-internal/scripts/build-ts.sh

@@ -0,0 +1 @@
+module.exports = require('@atlaspack/unified/types-internal');

packages/dev/eslint-plugin-internal/test/rules/no-relative-import.test.js

@@ -0,0 +1,3 @@
+// @flow
+
+export * from '@atlaspack/unified/src/types-internal/index.js';

packages/core/types-internal/CHANGELOG.md renamed to packages/shims/core-types-internal/CHANGELOG.md

@@ -0,0 +1,18 @@
+{
+  "name": "@atlaspack/types-internal",
+  "version": "2.14.6",
+  "license": "(MIT OR Apache-2.0)",
+  "main": "index.js",
+  "types": "index.d.ts",
+  "type": "commonjs",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/atlassian-labs/atlaspack.git"
+  },
+  "publishConfig": {
+    "access": "public"
+  },
+  "dependencies": {
+    "@atlaspack/unified": "2.14.1"
+  }
+}

packages/shims/core-types-internal/index.d.ts

@@ -3,7 +3,7 @@
 import {type PostHTMLNode, render} from 'posthtml-render';
 import {parseHTML, transformerOpts} from '../src/HTMLTransformer';
 import assert from 'assert';
-import type {PluginOptions} from '../../../core/types-internal/src';
+import type {PluginOptions} from '../../../unified/src/types-internal/index.js';
 
 function normalizeHTML(code: string): string {
   const ast = parseHTML(code, true);