New module to isolate static transients (#567)

* New module to isolate static transients

* Update author list

* Doc and naming

* Doc

Author: JulienPeloton

.ruff.toml

@@ -44,7 +44,6 @@ ignore = [
     "D400", "D401", "D100", "D102", "D103", "D104", "D415", "D419", "D301", 
     "E731",
     "N812", "N806", "N803", 
-    "PD901", 
     "PLR0913"
 ]
 

fink_science/ztf/hostless_detection/processor.py

@@ -229,9 +229,17 @@ def run_potential_hostless(
                         science_stamp, template_stamp
                     )
                 )
-                kstest_results.append([kstest_science, kstest_template, is_processed_true])
+                kstest_results.append([
+                    kstest_science,
+                    kstest_template,
+                    is_processed_true,
+                ])
             else:
-                kstest_results.append([default_result, default_result, is_processed_false])
+                kstest_results.append([
+                    default_result,
+                    default_result,
+                    is_processed_false,
+                ])
         else:
             kstest_results.append([default_result, default_result, is_processed_false])
     return pd.Series(kstest_results)

fink_science/ztf/transient_features/README.md

@@ -0,0 +1,17 @@
+# Features for static transients
+
+This module is based on the work of 
+1. https://ui.adsabs.harvard.edu/abs/2020ApJ...904...35P/abstract
+2. https://ui.adsabs.harvard.edu/abs/2020ApJ...895...32F/abstract
+3. https://zenodo.org/records/4054129
+
+we identified 6 new features to add:
+1. `faint`: `magpsf` is currently fainter than 19.8, or the source had a very recent detection fainter than 19.
+2. `pointunderneath`:  is likely sitting on top of or blended with a star in Pan-STARRS.
+3. `positivesubtraction`: is brighter than the template image.
+4. `real`: is likely a genuine astrophysical transient and not an artifact.
+5. `stationary`: is not a moving source.
+6. `brightstar`: is likely contaminated by a nearby bright star.
+7. `variablesource`: is likely a variable star
+
+Note that what is called `rock` in the initial filter is not necessary here as we already provide a column `roid` to assess the asteroid nature of an object.