Skip to content

Commit d40e999

Browse files
committed
[ty] Simplify concise TypedDict invalid-key messages
1 parent b8c4bee commit d40e999

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

crates/ty_python_semantic/resources/mdtest/comprehensions/basic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ y3: list[Person] = [{"name": n} for n in ["Alice", "Bob"]]
207207
reveal_type(y3) # revealed: list[Person]
208208

209209
# error: [invalid-assignment]
210-
# error: [invalid-key] "Unknown key "misspelled" for TypedDict `Person`: Unknown key "misspelled""
210+
# error: [invalid-key] "Unknown key "misspelled" for TypedDict `Person`"
211211
# error: [missing-typed-dict-key] "Missing required key 'name' in TypedDict `Person` constructor"
212212
y4: list[Person] = [{"misspelled": n} for n in ["Alice", "Bob"]]
213213
```

crates/ty_python_semantic/src/types/diagnostic.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4792,6 +4792,9 @@ pub(crate) fn report_invalid_key_on_typed_dict<'db>(
47924792
));
47934793
} else {
47944794
diagnostic.set_primary_message(format_args!("Unknown key \"{key}\""));
4795+
diagnostic.set_concise_message(format_args!(
4796+
"Unknown key \"{key}\" for TypedDict `{typed_dict_name}`",
4797+
));
47954798
}
47964799
}
47974800
_ => {

0 commit comments

Comments
 (0)