Reject multi-line f-string elements before Python 3.12

Author: charliermarsh

crates/ruff_python_formatter/tests/snapshots/format@expression__fstring.py.snap

@@ -1,6 +1,5 @@
 ---
 source: crates/ruff_python_formatter/tests/fixtures.rs
-input_file: crates/ruff_python_formatter/resources/test/fixtures/ruff/expression/fstring.py
 ---
 ## Input
 ```python
@@ -2436,3 +2435,27 @@ error[invalid-syntax]: Cannot reuse outer quote character in f-strings on Python
 179 | f"foo {'"bar"'}"
     |
 warning: Only accept new syntax errors if they are also present in the input. The formatter should not introduce syntax errors.
+
+error[invalid-syntax]: Cannot use line breaks in non-triple-quoted f-string replacement fields on Python 3.10 (syntax was added in Python 3.12)
+   --> fstring.py:572:8
+    |
+570 |         ttttteeeeeeeeest,
+571 |     ]
+572 | } more {
+    |        ^
+573 |     aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
+574 | }":
+    |
+warning: Only accept new syntax errors if they are also present in the input. The formatter should not introduce syntax errors.
+
+error[invalid-syntax]: Cannot use line breaks in non-triple-quoted f-string replacement fields on Python 3.10 (syntax was added in Python 3.12)
+   --> fstring.py:581:8
+    |
+579 |         ttttteeeeeeeeest,
+580 |     ]
+581 | } more {
+    |        ^
+582 |     aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
+583 | }":
+    |
+warning: Only accept new syntax errors if they are also present in the input. The formatter should not introduce syntax errors.

crates/ruff_python_parser/resources/inline/err/pep701_f_string_py311.py

@@ -6,6 +6,9 @@
 }'''
 f"{f"{f"{f"{f"{f"{1+1}"}"}"}"}"}"  # arbitrary nesting
 f"{f'''{"nested"} inner'''} outer" # nested (triple) quotes
+f"{
+    1
+}"
 f"test {a \
     } more"                        # line continuation
 f"""{f"""{x}"""}"""                # mark the whole triple quote

crates/ruff_python_parser/resources/inline/ok/pep701_f_string_py311.py

@@ -3,6 +3,9 @@
 f'outer {x:{"# not a comment"} }'
 f"""{f'''{f'{"# not a comment"}'}'''}"""
 f"""{f'''# before expression {f'# aro{f"#{1+1}#"}und #'}'''} # after expression"""
+f"""{
+    1
+}"""
 f"escape outside of \t {expr}\n"
 f"test\"abcd"
 f"{1:\x64}"  # escapes are valid in the format spec

crates/ruff_python_parser/resources/inline/ok/pep701_f_string_py312.py

@@ -6,5 +6,8 @@
 }'''
 f"{f"{f"{f"{f"{f"{1+1}"}"}"}"}"}"  # arbitrary nesting
 f"{f'''{"nested"} inner'''} outer" # nested (triple) quotes
+f"{
+    1
+}"
 f"test {a \
     } more"                        # line continuation

crates/ruff_python_parser/src/error.rs

@@ -501,6 +501,7 @@ pub enum StarTupleKind {
 pub enum FStringKind {
     Backslash,
     Comment,
+    LineBreak,
     NestedQuote,
 }
 
@@ -732,6 +733,11 @@ pub enum UnsupportedSyntaxErrorKind {
     ///     bag['bag']  # recursive bags!
     /// }'''
     ///
+    /// # line breaks in a non-triple-quoted replacement field
+    /// f"{
+    ///     1
+    /// }"
+    ///
     /// # arbitrary nesting
     /// f"{f"{f"{f"{f"{f"{1+1}"}"}"}"}"}"
     /// ```
@@ -991,6 +997,9 @@ impl Display for UnsupportedSyntaxError {
             UnsupportedSyntaxErrorKind::Pep701FString(FStringKind::Comment) => {
                 "Cannot use comments in f-strings"
             }
+            UnsupportedSyntaxErrorKind::Pep701FString(FStringKind::LineBreak) => {
+                "Cannot use line breaks in non-triple-quoted f-string replacement fields"
+            }
             UnsupportedSyntaxErrorKind::Pep701FString(FStringKind::NestedQuote) => {
                 "Cannot reuse outer quote character in f-strings"
             }

crates/ruff_python_parser/src/parser/expression.rs

@@ -21,10 +21,7 @@ use crate::string::{
 };
 use crate::token::TokenValue;
 use crate::token_set::TokenSet;
-use crate::{
-    InterpolatedStringErrorType, Mode, ParseErrorType, UnsupportedSyntaxError,
-    UnsupportedSyntaxErrorKind,
-};
+use crate::{InterpolatedStringErrorType, Mode, ParseErrorType, UnsupportedSyntaxErrorKind};
 
 use super::{InterpolatedStringElementsKind, Parenthesized, RecoveryContextKind};
 
@@ -1562,18 +1559,6 @@ impl<'src> Parser<'src> {
         }
     }
 
-    /// Check `range` for comment tokens and report an `UnsupportedSyntaxError` for each one found.
-    fn check_fstring_comments(&mut self, range: TextRange) {
-        self.unsupported_syntax_errors
-            .extend(self.tokens.in_range(range).iter().filter_map(|token| {
-                token.kind().is_comment().then_some(UnsupportedSyntaxError {
-                    kind: UnsupportedSyntaxErrorKind::Pep701FString(FStringKind::Comment),
-                    range: token.range(),
-                    target_version: self.options.target_version,
-                })
-            }));
-    }
-
     /// Parses a list of f/t-string elements.
     ///
     /// # Panics
@@ -1852,6 +1837,9 @@ impl<'src> Parser<'src> {
         // }'''
         // f"{f"{f"{f"{f"{f"{1+1}"}"}"}"}"}"  # arbitrary nesting
         // f"{f'''{"nested"} inner'''} outer" # nested (triple) quotes
+        // f"{
+        //     1
+        // }"
         // f"test {a \
         //     } more"                        # line continuation
 
@@ -1873,6 +1861,9 @@ impl<'src> Parser<'src> {
         // f'outer {x:{"# not a comment"} }'
         // f"""{f'''{f'{"# not a comment"}'}'''}"""
         // f"""{f'''# before expression {f'# aro{f"#{1+1}#"}und #'}'''} # after expression"""
+        // f"""{
+        //     1
+        // }"""
         // f"escape outside of \t {expr}\n"
         // f"test\"abcd"
         // f"{1:\x64}"  # escapes are valid in the format spec
@@ -1887,6 +1878,9 @@ impl<'src> Parser<'src> {
         // }'''
         // f"{f"{f"{f"{f"{f"{1+1}"}"}"}"}"}"  # arbitrary nesting
         // f"{f'''{"nested"} inner'''} outer" # nested (triple) quotes
+        // f"{
+        //     1
+        // }"
         // f"test {a \
         //     } more"                        # line continuation
         // f"""{f"""{x}"""}"""                # mark the whole triple quote
@@ -1918,13 +1912,37 @@ impl<'src> Parser<'src> {
                 .map(|format_spec| TextRange::new(range.start(), format_spec.start()))
                 .unwrap_or(range);
 
+            let source = self.source[range].as_bytes();
+            let has_line_break =
+                !flags.is_triple_quoted() && memchr::memchr2(b'\n', b'\r', source).is_some();
+            let backslash_ranges = memchr::memchr_iter(b'\\', source)
+                .map(|slash_position| {
+                    let slash_position = TextSize::try_from(slash_position).unwrap();
+                    TextRange::at(range.start() + slash_position, '\\'.text_len())
+                })
+                .collect::<Vec<_>>();
+            let comment_ranges = self
+                .tokens
+                .in_range(range)
+                .iter()
+                .filter_map(|token| token.kind().is_comment().then_some(token.range()))
+                .collect::<Vec<_>>();
+
+            // Before Python 3.12, replacement fields could only span physical lines when the
+            // outer f-string was triple-quoted.
+            if has_line_break && backslash_ranges.is_empty() && comment_ranges.is_empty() {
+                self.add_unsupported_syntax_error(
+                    UnsupportedSyntaxErrorKind::Pep701FString(FStringKind::LineBreak),
+                    TextRange::at(range.start(), '{'.text_len()),
+                );
+            }
+
             let quote_bytes = flags.quote_str().as_bytes();
             let quote_len = flags.quote_len();
-            for slash_position in memchr::memchr_iter(b'\\', self.source[range].as_bytes()) {
-                let slash_position = TextSize::try_from(slash_position).unwrap();
+            for backslash_range in backslash_ranges {
                 self.add_unsupported_syntax_error(
                     UnsupportedSyntaxErrorKind::Pep701FString(FStringKind::Backslash),
-                    TextRange::at(range.start() + slash_position, '\\'.text_len()),
+                    backslash_range,
                 );
             }
 
@@ -1938,7 +1956,12 @@ impl<'src> Parser<'src> {
                 );
             }
 
-            self.check_fstring_comments(range);
+            for comment_range in comment_ranges {
+                self.add_unsupported_syntax_error(
+                    UnsupportedSyntaxErrorKind::Pep701FString(FStringKind::Comment),
+                    comment_range,
+                );
+            }
         }
 
         ast::InterpolatedElement {