Fix #184

asaskevich · asaskevich · commit 4918b99a7cb9 · 2017-04-25T15:12:27.000+03:00
diff --git a/validator.go b/validator.go
@@ -461,7 +461,7 @@ func IsDNSName(str string) bool {
 		// constraints already violated
 		return false
 	}
-	return rxDNSName.MatchString(str)
+	return !IsIP(str) && rxDNSName.MatchString(str)
 }
 
 // IsDialString validates the given string for usage with the various Dial() functions
diff --git a/validator_test.go b/validator_test.go
@@ -1512,6 +1512,7 @@ func TestIsDNSName(t *testing.T) {
 		{"localhost.localdomain.üntern", false},
 		{"127.0.0.1", false},
 		{"[::1]", false},
+		{"50.50.50.50", false},
 		{"localhost.localdomain.intern:65535", false},
 		{"漢字汉字", false},
 		{"www.jubfvq1v3p38i51622y0dvmdk1mymowjyeu26gbtw9andgynj1gg8z3msb1kl5z6906k846pj3sulm4kiyk82ln5teqj9nsht59opr0cs5ssltx78lfyvml19lfq1wp4usbl0o36cmiykch1vywbttcus1p9yu0669h8fj4ll7a6bmop505908s1m83q2ec2qr9nbvql2589adma3xsq2o38os2z3dmfh2tth4is4ixyfasasasefqwe4t2ub2fz1rme.de", false},

Original file line number	Diff line number	Diff line change
`@@ -461,7 +461,7 @@ func IsDNSName(str string) bool {`
`461`	`461`	`// constraints already violated`
`462`	`462`	`return false`
`463`	`463`	`}`
`464`		`- return rxDNSName.MatchString(str)`
	`464`	`+ return !IsIP(str) && rxDNSName.MatchString(str)`
`465`	`465`	`}`
`466`	`466`
`467`	`467`	`// IsDialString validates the given string for usage with the various Dial() functions`