[ARQ-1248] Documented DerbyDropTable stored procedure.

Author: bartoszmajsak

int-tests-testng/src/test/java/org/jboss/arquillian/integration/persistence/datasource/derby/DerbyDropTable.java

@@ -22,26 +22,45 @@
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
 
+/**
+ *
+ * Registered as stored procedure for Apache Derby database.
+ * It's a workaround for missing "DROP IF EXISTS" feature.
+ *
+ * The main rationale is to have repeatable tests where you can create drop/create tables safely.
+ *
+ */
 public class DerbyDropTable
 {
 
    public static void dropTable(String schema, String table)
    {
       Connection conn = null;
+      PreparedStatement preparedStatement = null;
       try
       {
          conn = DriverManager.getConnection("jdbc:derby:target/db/derby");
-         PreparedStatement ps = conn.prepareStatement("drop table " + schema + "." + table);
-         ps.executeUpdate();
+         preparedStatement = conn.prepareStatement("drop table " + schema + "." + table);
+         preparedStatement.executeUpdate();
          conn.commit();
-         ps.close();
       }
       catch (SQLException e)
       {
          // IGNORE - it fails when you try to drop non-existing table, but we want to continue
       }
       finally
       {
+         if (preparedStatement !=null)
+         {
+            try
+            {
+               preparedStatement.close();
+            }
+            catch (SQLException e)
+            {
+               throw new RuntimeException("Failed closing prepared statement", e);
+            }
+         }
          if (conn != null)
          {
             try
@@ -50,7 +69,7 @@ public static void dropTable(String schema, String table)
             }
             catch (SQLException e)
             {
-               // IGNORE
+               throw new RuntimeException("Failed closing connection", e);
             }
          }
       }

int-tests/src/test/java/org/jboss/arquillian/integration/persistence/datasource/derby/DerbyDropTable.java

@@ -22,26 +22,45 @@
 import java.sql.PreparedStatement;
 import java.sql.SQLException;
 
+/**
+ *
+ * Registered as stored procedure for Apache Derby database.
+ * It's a workaround for missing "DROP IF EXISTS" feature.
+ *
+ * The main rationale is to have repeatable tests where you can create drop/create tables safely.
+ *
+ */
 public class DerbyDropTable
 {
 
    public static void dropTable(String schema, String table)
    {
       Connection conn = null;
+      PreparedStatement preparedStatement = null;
       try
       {
          conn = DriverManager.getConnection("jdbc:derby:target/db/derby");
-         PreparedStatement ps = conn.prepareStatement("drop table " + schema + "." + table);
-         ps.executeUpdate();
+         preparedStatement = conn.prepareStatement("drop table " + schema + "." + table);
+         preparedStatement.executeUpdate();
          conn.commit();
-         ps.close();
       }
       catch (SQLException e)
       {
          // IGNORE - it fails when you try to drop non-existing table, but we want to continue
       }
       finally
       {
+         if (preparedStatement !=null)
+         {
+            try
+            {
+               preparedStatement.close();
+            }
+            catch (SQLException e)
+            {
+               throw new RuntimeException("Failed closing prepared statement", e);
+            }
+         }
          if (conn != null)
          {
             try
@@ -50,7 +69,7 @@ public static void dropTable(String schema, String table)
             }
             catch (SQLException e)
             {
-               // IGNORE
+               throw new RuntimeException("Failed closing connection", e);
             }
          }
       }