Skip to content

Commit 74f14d2

Browse files
Joibeleduardodbr
andauthored
fix: retry strategy being ignored by daemoned nodes. Fix #14715 (cherry-pick release-3.7) (#14835)
Signed-off-by: Eduardo Rodrigues <[email protected]> Co-authored-by: Eduardo Rodrigues <[email protected]>
1 parent 8aac933 commit 74f14d2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

workflow/controller/operator.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2176,7 +2176,7 @@ func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string,
21762176
childNodeIDs, lastChildNode := getChildNodeIdsAndLastRetriedNode(retryParentNode, woc.wf.Status.Nodes)
21772177

21782178
// The retry node might have completed by now.
2179-
if retryParentNode.Fulfilled() && woc.childrenFulfilled(retryParentNode) { // if retry node is daemoned we want to check those explicitly
2179+
if retryParentNode.Fulfilled() && (woc.childrenFulfilled(retryParentNode) || (retryParentNode.IsDaemoned() && retryParentNode.FailedOrError())) { // if retry node is daemoned we want to check those explicitly
21802180
// If retry node has completed, set the output of the last child node to its output.
21812181
// Runtime parameters (e.g., `status`, `resourceDuration`) in the output will be used to emit metrics.
21822182
if lastChildNode != nil {

0 commit comments

Comments
 (0)