Skip to content

Commit b6af657

Browse files
fix: add missing fields in listrepositories (#20991) (#21129)
This fixes a regression in 2.12. Before 2.12 githubAppInstallationID, `githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with 2.12 the repo is retrieved with getRepositories`, which does not include those fields. To fix this, add those missing fields to `ListRepositories`. Signed-off-by: Blake Pettersson <[email protected]>
1 parent a3624a3 commit b6af657

File tree

1 file changed

+15
-12
lines changed

1 file changed

+15
-12
lines changed

server/repository/repository.go

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -188,18 +188,21 @@ func (s *Server) ListRepositories(ctx context.Context, q *repositorypkg.RepoQuer
188188
}
189189
// remove secrets
190190
items = append(items, &appsv1.Repository{
191-
Repo: repo.Repo,
192-
Type: rType,
193-
Name: repo.Name,
194-
Username: repo.Username,
195-
Insecure: repo.IsInsecure(),
196-
EnableLFS: repo.EnableLFS,
197-
EnableOCI: repo.EnableOCI,
198-
Proxy: repo.Proxy,
199-
NoProxy: repo.NoProxy,
200-
Project: repo.Project,
201-
ForceHttpBasicAuth: repo.ForceHttpBasicAuth,
202-
InheritedCreds: repo.InheritedCreds,
191+
Repo: repo.Repo,
192+
Type: rType,
193+
Name: repo.Name,
194+
Username: repo.Username,
195+
Insecure: repo.IsInsecure(),
196+
EnableLFS: repo.EnableLFS,
197+
EnableOCI: repo.EnableOCI,
198+
Proxy: repo.Proxy,
199+
NoProxy: repo.NoProxy,
200+
Project: repo.Project,
201+
ForceHttpBasicAuth: repo.ForceHttpBasicAuth,
202+
InheritedCreds: repo.InheritedCreds,
203+
GithubAppId: repo.GithubAppId,
204+
GithubAppInstallationId: repo.GithubAppInstallationId,
205+
GitHubAppEnterpriseBaseURL: repo.GitHubAppEnterpriseBaseURL,
203206
})
204207
}
205208
}

0 commit comments

Comments
 (0)