Skip to content

#1445 Ensure directories.user exists. #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2022
Merged

#1445 Ensure directories.user exists. #1448

merged 1 commit into from
Sep 21, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

IDE2 creates the sketchbook folder (directories.user) on startup if it's missing.

Change description

Other information

Closes #1445

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Ensure directories.user exists.
c90bede 
Closes #1445

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 16, 2022
francescospissu
francescospissu approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it by renaming my sketchbook folder and, unlike before this fix, a new folder has been created on startup as expected. Nice work 👍

@per1234 per1234 mentioned this pull request Sep 18, 2022
Closed
3 tasks
@kittaakos kittaakos merged commit 6983c5b into main Sep 21, 2022
@kittaakos kittaakos deleted the #1445 branch September 21, 2022 07:10
@per1234 per1234 mentioned this pull request Oct 1, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescospissu francescospissu francescospissu approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sketchbook folder not created on startup
2 participants
@kittaakos @francescospissu