Skip to content

Add an option to format logs with JSON #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 30, 2019
Merged

Add an option to format logs with JSON #378

merged 3 commits into from
Aug 30, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Aug 29, 2019

This PR adds the --log-format option.

Same as you can do with output, let users choose the format of the logged informations to ease parsing the CLI output.

Also accepts uppercase strings when parsing format args, i.e. --format JSON will work as good as --format json.

rsora
rsora approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit aef7461 into master Aug 30, 2019
@masci masci deleted the massi/logformat branch August 30, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rsora rsora rsora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masci @rsora