Skip to content

Commit a59bb3b

Browse files
committed
Use standard order of keys in "Check Certificates" workflow steps
Although machines don't care which order the keys occur in, since the `jobs[].<job_id>.steps[].env` key declares the environment variables used in the step, it is most intuitive for it to be placed before the `run` or `uses` key.
1 parent 86f2afc commit a59bb3b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/check-certificates.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ jobs:
6565
# See: https://github.com/rtCamp/action-slack-notify
6666
- name: Slack notification of certificate verification failure
6767
if: failure()
68-
uses: rtCamp/action-slack-notify@v2
6968
env:
7069
SLACK_WEBHOOK: ${{ secrets.TEAM_TOOLING_CHANNEL_SLACK_WEBHOOK }}
7170
SLACK_MESSAGE: |
@@ -74,6 +73,7 @@ jobs:
7473
:warning::warning::warning::warning:
7574
SLACK_COLOR: danger
7675
MSG_MINIMAL: true
76+
uses: rtCamp/action-slack-notify@v2
7777

7878
- name: Get days remaining before certificate expiration date
7979
env:
@@ -119,7 +119,6 @@ jobs:
119119
- name: Slack notification of pending certificate expiration
120120
# Don't send spurious expiration notification if verification fails
121121
if: failure() && steps.check-expiration.outcome == 'failure'
122-
uses: rtCamp/action-slack-notify@v2
123122
env:
124123
SLACK_WEBHOOK: ${{ secrets.TEAM_TOOLING_CHANNEL_SLACK_WEBHOOK }}
125124
SLACK_MESSAGE: |
@@ -128,3 +127,4 @@ jobs:
128127
:warning::warning::warning::warning:
129128
SLACK_COLOR: danger
130129
MSG_MINIMAL: true
130+
uses: rtCamp/action-slack-notify@v2

0 commit comments

Comments
 (0)