add completion for core uninstall

maybe could be done better (filter and remove the manually installed ones)

Author: umbynos

cli/arguments/completion.go

@@ -7,6 +7,7 @@ import (
 	"github.com/arduino/arduino-cli/cli/instance"
 	"github.com/arduino/arduino-cli/commands"
 	"github.com/arduino/arduino-cli/commands/board"
+	"github.com/arduino/arduino-cli/commands/core"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 )
 
@@ -88,3 +89,21 @@ func GetInstalledProgrammers(toComplete string) []string {
 	}
 	return res
 }
+
+// GetUninstallableCores is an helper function useful to autocomplete.
+// It returns a list of cores which can be uninstalled
+func GetUninstallableCores(toComplete string) []string {
+	inst := instance.CreateAndInit() // TODO optimize this: it does not make sense to create an instance everytime
+
+	platforms, _ := core.GetPlatforms(&rpc.PlatformListRequest{
+		Instance:      inst,
+		UpdatableOnly: false,
+		All:           false,
+	})
+	var res []string
+	// transform the data structure for the completion
+	for _, i := range platforms {
+		res = append(res, i.GetId())
+	}
+	return res
+}

cli/core/uninstall.go

@@ -39,6 +39,9 @@ func initUninstallCommand() *cobra.Command {
 		Example: "  " + os.Args[0] + " core uninstall arduino:samd\n",
 		Args:    cobra.MinimumNArgs(1),
 		Run:     runUninstallCommand,
+		ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+			return arguments.GetUninstallableCores(toComplete), cobra.ShellCompDirectiveDefault
+		},
 	}
 }
 

i18n/data/en.po

@@ -729,7 +729,7 @@ msgstr "Error during build: %v"
 msgid "Error during install: %v"
 msgstr "Error during install: %v"
 
-#: cli/core/uninstall.go:68
+#: cli/core/uninstall.go:71
 msgid "Error during uninstall: %v"
 msgstr "Error during uninstall: %v"
 
@@ -1218,7 +1218,7 @@ msgstr "Invalid additional URL: %v"
 
 #: cli/core/download.go:55
 #: cli/core/install.go:92
-#: cli/core/uninstall.go:51
+#: cli/core/uninstall.go:54
 #: cli/core/upgrade.go:81
 #: cli/lib/download.go:50
 #: cli/lib/uninstall.go:51
@@ -1266,7 +1266,7 @@ msgstr "Invalid output format: %s"
 msgid "Invalid package index in %s"
 msgstr "Invalid package index in %s"
 
-#: cli/core/uninstall.go:57
+#: cli/core/uninstall.go:60
 msgid "Invalid parameter %s: version not allowed"
 msgstr "Invalid parameter %s: version not allowed"