From 6fe3cae389e222177c8818ce67c27bd6796d4826 Mon Sep 17 00:00:00 2001 From: per1234 Date: Wed, 13 Jan 2021 00:40:57 -0800 Subject: [PATCH 1/3] Use modern version of arduino/compile-sketches action The action has been moved to a dedicated repository and the previous repository is no longer being maintained. --- .github/workflows/compile-examples.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index f36cce99..a35f557b 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -20,6 +20,7 @@ jobs: LIBRARIES: Arduino_DebugUtils WiFi101 WiFiNINA MKRGSM MKRNB MKRWAN ARDUINOCORE_MBED_STAGING_PATH: extras/ArduinoCore-mbed ARDUINOCORE_API_STAGING_PATH: extras/ArduinoCore-API + SKETCHES_REPORTS_PATH: sketches-reports strategy: matrix: board: @@ -96,17 +97,18 @@ jobs: mv "${{ env.ARDUINOCORE_API_STAGING_PATH }}/api" "${{ env.ARDUINOCORE_MBED_STAGING_PATH }}/cores/arduino" - name: Compile examples - uses: arduino/actions/libraries/compile-examples@master + uses: arduino/compile-sketches@main with: platforms: ${{ matrix.platforms }} fqbn: ${{ matrix.board.fqbn }} libraries: ${{ env.LIBRARIES }} size-report-sketch: 'ConnectionHandlerDemo' enable-size-deltas-report: 'true' + sketches-report-path: ${{ env.SKETCHES_REPORTS_PATH }} - name: Save memory usage change report as artifact if: github.event_name == 'pull_request' uses: actions/upload-artifact@v1 with: - name: 'size-deltas-reports' - path: 'size-deltas-reports' + name: ${{ env.SKETCHES_REPORTS_PATH }} + path: ${{ env.SKETCHES_REPORTS_PATH }} From 0c52270dbf72ad2c2c4ac1c75825a5a519f54328 Mon Sep 17 00:00:00 2001 From: per1234 Date: Tue, 12 Jan 2021 20:27:52 -0800 Subject: [PATCH 2/3] Add ESP32 board to "Compile Examples" CI workflow ESP32 support has been added to the library, so the examples compilation smoke test should be done for this architecture as well. --- .github/workflows/compile-examples.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index a35f557b..1b9a50fe 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -44,6 +44,8 @@ jobs: platform-name: arduino:mbed - fqbn: "esp8266:esp8266:huzzah" platform-name: esp8266:esp8266 + - fqbn: "esp32:esp32:esp32" + platform-name: esp32:esp32 # Make board type-specific customizations to the matrix jobs include: @@ -66,6 +68,12 @@ jobs: # Install ESP8266 platform via Boards Manager - name: esp8266:esp8266 source-url: https://arduino.esp8266.com/stable/package_esp8266com_index.json + - board: + platform-name: esp32:esp32 + platforms: | + # Install ESP32 platform via Boards Manager + - name: esp32:esp32 + source-url: https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json steps: - uses: actions/checkout@v1 @@ -96,6 +104,10 @@ jobs: run: | mv "${{ env.ARDUINOCORE_API_STAGING_PATH }}/api" "${{ env.ARDUINOCORE_MBED_STAGING_PATH }}/cores/arduino" + - name: Install ESP32 platform dependencies + if: matrix.board.platform-name == 'esp32:esp32' + run: pip3 install pyserial + - name: Compile examples uses: arduino/compile-sketches@main with: From f624fbdc598d625660b622ab7e96f7f3dc3ddbf0 Mon Sep 17 00:00:00 2001 From: Alexander Entinger Date: Wed, 13 Jan 2021 09:17:19 +0100 Subject: [PATCH 3/3] Fix -Wreorder error during CI build. --- src/Arduino_ConnectionHandler.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Arduino_ConnectionHandler.cpp b/src/Arduino_ConnectionHandler.cpp index 51f63fc8..943fa1d9 100644 --- a/src/Arduino_ConnectionHandler.cpp +++ b/src/Arduino_ConnectionHandler.cpp @@ -27,8 +27,8 @@ ConnectionHandler::ConnectionHandler(bool const keep_alive) : _keep_alive{keep_alive} -, _current_net_connection_state{NetworkConnectionState::INIT} , _lastConnectionTickTime{millis()} +, _current_net_connection_state{NetworkConnectionState::INIT} { }