Skip to content

Commit 48c9584

Browse files
Anson Huangshawnguo2
authored andcommitted
ARM: imx: improve the comment of CCM lpm SW workaround
Improve the comment of SW workaround for CCM lpm issue using hardware errata description to avoid confusion. ERR007265: CCM: When improper low-power sequence is used, the SoC enters low power mode before the ARM core executes WFI. Software workaround: 1) Software should trigger IRQ torvalds#32 (IOMUX) to be always pending by setting IOMUX_GPR1_GINT. 2) Software should then unmask IRQ torvalds#32 in GPC before setting CCM Low-Power mode. 3) Software should mask IRQ torvalds#32 right after CCM Low-Power mode is set (set bits 0-1 of CCM_CLPCR). Signed-off-by: Anson Huang <[email protected]> Signed-off-by: Shawn Guo <[email protected]>
1 parent b4e844f commit 48c9584

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

arch/arm/mach-imx/pm-imx6q.c

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,16 @@ int imx6q_set_lpm(enum mxc_cpu_pwr_mode mode)
156156
}
157157

158158
/*
159-
* Unmask the always pending IOMUXC interrupt #32 as wakeup source to
160-
* deassert dsm_request signal, so that we can ensure dsm_request
161-
* is not asserted when we're going to write CLPCR register to set LPM.
162-
* After setting up LPM bits, we need to mask this wakeup source.
159+
* ERR007265: CCM: When improper low-power sequence is used,
160+
* the SoC enters low power mode before the ARM core executes WFI.
161+
*
162+
* Software workaround:
163+
* 1) Software should trigger IRQ #32 (IOMUX) to be always pending
164+
* by setting IOMUX_GPR1_GINT.
165+
* 2) Software should then unmask IRQ #32 in GPC before setting CCM
166+
* Low-Power mode.
167+
* 3) Software should mask IRQ #32 right after CCM Low-Power mode
168+
* is set (set bits 0-1 of CCM_CLPCR).
163169
*/
164170
iomuxc_irq_desc = irq_to_desc(32);
165171
imx_gpc_irq_unmask(&iomuxc_irq_desc->irq_data);
@@ -219,6 +225,8 @@ void __init imx6q_pm_init(void)
219225
WARN_ON(!ccm_base);
220226

221227
/*
228+
* This is for SW workaround step #1 of ERR007265, see comments
229+
* in imx6q_set_lpm for details of this errata.
222230
* Force IOMUXC irq pending, so that the interrupt to GPC can be
223231
* used to deassert dsm_request signal when the signal gets
224232
* asserted unexpectedly.

0 commit comments

Comments
 (0)