Merge pull request #119 from lorentey/remove-heap-views

[Heap] Remove Heap's `ascending` and `descending` views

Author: lorentey

Documentation/Heap.md

@@ -104,17 +104,7 @@ We also have non-optional flavors that assume the heap isn't empty, `removeMin()
 
 ### Iteration
 
-`Heap` itself doesn't conform to `Sequence` because of the potential confusion around which direction it should iterate (largest-to-smallest? smallest-to-largest?). Instead, we expose two iterators that conform to `Sequence`:
-
-```swift
-for val in heap.ascending {
-    ...
-}
-
-for val in heap.descending {
-    ...
-}
-```
+`Heap` itself doesn't conform to `Sequence` because of the potential confusion around which direction it should iterate (largest-to-smallest? smallest-to-largest?).
 
 ### Performance
 

Sources/PriorityQueueModule/Heap+OrderedViews.swift

@@ -90,9 +90,12 @@ final class HeapTests: XCTestCase {
     heap.insert(contentsOf: sequence(first: 1, next: addTwo(_:)).prefix(20))
     XCTAssertEqual(heap.count, 40)
 
-    for (idx, i) in heap.ascending.enumerated() {
-      XCTAssertEqual(idx, i)
+    var i = 0
+    while let min = heap.popMin() {
+      XCTAssertEqual(min, i)
+      i += 1
     }
+    XCTAssertEqual(i, 40)
   }
 
   func test_min() {
@@ -403,21 +406,5 @@ final class HeapTests: XCTestCase {
     XCTAssertEqual(heap.popMax(), 3)
     XCTAssertEqual(heap.popMax(), 1)
   }
-
-  func test_sequenceConformance() {
-    let heap = Heap<Int>((0...50).shuffled())
-
-    var increment = 0
-    for val in heap.ascending {
-      XCTAssertEqual(increment, val)
-      increment += 1
-    }
-
-    increment = 50
-    for val in heap.descending {
-      XCTAssertEqual(increment, val)
-      increment -= 1
-    }
-  }
 }
 #endif