feat: Label system.exec, string.pack, string.html_safe

Author: kgilpin

lib/appmap/builtin_hooks/marshal.yml

@@ -0,0 +1,13 @@
+- methods:
+  - Open3#capture2
+  - Open3#capture2e
+  - Open3#capture3
+  - Open3#pipeline
+  - Open3#pipeline_r
+  - Open3#pipeline_rw
+  - Open3#pipeline_start
+  - Open3#pipeline_w
+  - Open3#popen2
+  - Open3#popen2e
+  - Open3#popen3
+  label: system.exec

lib/appmap/builtin_hooks/open3.yml

@@ -0,0 +1,39 @@
+- methods:
+  - Marshal#load
+  - Marshal#restore
+  require_name: ruby
+  label: deserialize.unsafe
+- method: Marshal#dump
+  require_name: ruby
+  label: serialize
+- method: String#pack
+  require_name: ruby
+  label: string.pack
+- methods:
+  - String#unpack
+  - String#unpack1
+  require_name: ruby
+  label: string.unpack
+- methods:
+  # TODO: eval does not happen in the right context, and therefore any new constants
+  # which are defined are placed on the wrong module/class.
+#  - Kernel#eval
+  - Binding#eval
+  - BasicObject#instance_eval
+# These methods cannot be hooked as far as I can tell.
+# Why? When calling one of these functions, the context at the point of 
+# definition is used. It's not possible to bind class_eval to a new context.
+#  - Module#class_eval
+#  - Module#module_eval
+  require_name: ruby
+  label: lang.eval
+- methods:
+  - IO#popen
+  - Kernel#exec
+  - Kernel#spawn
+  - Kernel#syscall
+  - Kernel#system
+  - Process#exec
+  - Process#spawn
+  require_name: ruby
+  label: system.exec

lib/appmap/builtin_hooks/ruby.yml

@@ -11,3 +11,7 @@
   label: mvc.template.resolver
   handler_class: AppMap::Handler::Rails::Template::ResolverHandler
   require_name: action_view
+- methods:
+  - ActionView::Helpers::SanitizeHelper#sanitize
+  label: string.html_safe
+  require_name: action_view

lib/appmap/gem_hooks/actionview.yml

@@ -24,7 +24,7 @@ def test_record_gem
       appmap_file = 'tmp/appmap/minitest/Parser_parser.appmap.json'
       appmap = JSON.parse(File.read(appmap_file))
       events = appmap['events']
-      assert_equal 2, events.size
+      assert_equal 6, events.size
       assert_equal 'call', events.first['event']
       assert_equal 'default_parser', events.first['method_id']
       assert_match /\lib\/parser\/base\.rb$/, events.first['path']