feat: Record parameter and return value size

Author: kgilpin

lib/appmap/event.rb

@@ -243,6 +243,7 @@ def build_from_invocation(defined_class, method, receiver, arguments, event: Met
                 value: display_string(value),
                 kind: param_type
                 }.tap do |param|
+                  param[:size] = value.size if value.respond_to?(:size) && value.is_a?(Enumerable)
                   add_schema param, value
                 end
             end
@@ -308,6 +309,7 @@ def build_from_invocation(parent_id, return_value, exception, elapsed: nil, even
                 value: display_string(return_value),
                 object_id: return_value.__id__
               }.tap do |param|
+                param[:size] = return_value.size if return_value.respond_to?(:size) && return_value.is_a?(Enumerable)
                 add_schema param, return_value, always: parameter_schema
               end
             end

spec/handler/eval_spec.rb

@@ -32,7 +32,7 @@ def record_block
     expect(events[0]).to match hash_including \
       defined_class: 'Kernel',
       method_id: 'eval',
-      parameters: [{ class: 'Array', kind: :rest, name: 'arg', value: '[12]' }]
+      parameters: [{ class: 'Array', kind: :rest, name: 'arg', size: 1, value: '[12]' }]
   end
 
   # a la Ruby 2.6.3 ruby-token.rb

spec/hook_spec.rb

@@ -491,6 +491,7 @@ def test_hook_behavior(file, events_yaml, setup: nil, &block)
         :class: Array
         :value: "[4, 5]"
         :kind: :rest
+        :size: 2
       - :name: :kw1
         :class: String
         :value: one
@@ -503,6 +504,7 @@ def test_hook_behavior(file, events_yaml, setup: nil, &block)
         :class: Hash
         :value: "{:kw3=>:three}"
         :kind: :keyrest
+        :size: 1
       :receiver:
         :class: InstanceMethod
         :value: Instance Method fixture
@@ -1139,6 +1141,7 @@ def secure_compare(a, b)
         :class: Array
         :value: "[foo]"
         :kind: :rest
+        :size: 1
       - :name: :kw1
         :class: String
         :value: kw1
@@ -1151,6 +1154,7 @@ def secure_compare(a, b)
         :class: Hash
         :value: "{}"
         :kind: :keyrest
+        :size: 0
       :receiver:
         :class: ReportParameters
         :value: ReportParameters
@@ -1160,6 +1164,7 @@ def secure_compare(a, b)
       :return_value:
         :class: Array
         :value: "[[:rest, :args], [:keyreq, :kw1], [:key, :kw2], [:keyrest, :kws]]"
+        :size: 4
     YAML
     parameters = [[:rest, :args], [:keyreq, :kw1], [:key, :kw2], [:keyrest, :kws]]
     test_hook_behavior 'spec/fixtures/hook/report_parameters.rb', events do

spec/rails_recording_spec.rb

@@ -73,6 +73,7 @@ def rails_versions
                 'name' => 'params',
                 'class' => 'ActiveSupport::HashWithIndifferentAccess',
                 'object_id' => Integer,
+                'size' => 1,
                 'value' => '{login=>alice}',
                 'kind' => 'req'
               ),

test/expectations/openssl_test_key_sign2-3.1.json

@@ -26,7 +26,8 @@
         "name": "arg",
         "class": "Array",
         "value": "[e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855, the document]",
-        "kind": "rest"
+        "kind": "rest",
+        "size": 2
       }
     ],
     "receiver": {