feat: Don't auto-enable requests recording in 'test'

Author: kgilpin

lib/appmap/detect_enabled.rb

@@ -30,17 +30,16 @@ def enabled?
       @@detected_for_method[@recording_method] = enabled
 
       if @recording_method
-        if enabled
+        if enabled && enabled_by_app_env?
           warn AppMap::Util.color("AppMap #{@recording_method.nil? ? '' : "#{@recording_method} "}recording is enabled because #{message}", :magenta)
-          # Inform the user that legacy APPMAP=true isn't required any more
         end
       end
 
       enabled
     end
 
     def detect_enabled
-      detection_functions = %i[globally_disabled? recording_method_disabled? globally_enabled? recording_method_enabled? enabled_by_app_env?]
+      detection_functions = %i[globally_disabled? recording_method_disabled? enabled_by_app_env? recording_method_enabled? globally_enabled?]
 
       message, enabled = []
       while enabled.nil? && !detection_functions.empty?
@@ -57,7 +56,7 @@ def detect_enabled
 
     def enabled_by_app_env?
       env_name, app_env = detect_app_env
-      if %i[rspec minitest].member?(@recording_method)
+      if %i[rspec minitest cucumber].member?(@recording_method)
         return [ "#{env_name} is '#{app_env}'", true ] if app_env == 'test'
       end
 
@@ -79,7 +78,10 @@ def detect_app_env
     end
 
     def globally_enabled?
-      [ 'APPMAP=true', true ] if @recording_method.nil? && ['APPMAP'] == 'true'
+      # Don't auto-enable request recording in the 'test' environment, because users probably don't want
+      # AppMaps of both test cases and requests. Requests recording can always be enabled by APPMAP_RECORD_REQUESTS=true.
+      requests_recording_in_test = -> () { [ :requests ].member?(@recording_method) && detect_app_env == 'test' }
+      [ 'APPMAP=true', true ] if ENV['APPMAP'] == 'true' && !requests_recording_in_test.()
     end
 
     def globally_disabled?

spec/detect_enabled_spec.rb

@@ -18,7 +18,7 @@
   end
 
   describe 'recording_method' do
-    describe 'undefined' do
+    describe 'nil' do
       let(:recording_method) { nil }
       it_should_behave_like 'disabled'
 
@@ -98,7 +98,7 @@
       end
     end
 
-    %w[rspec minitest].each do |test_framework|
+    %w[rspec minitest cucumber].each do |test_framework|
       describe test_framework do
         let(:recording_method) { test_framework.to_sym }
         it_should_behave_like 'disabled'