Skip to content

Commit 8d21df2

Browse files
committed
Fixing some tests using deprecating fetch method
1 parent fdb10f5 commit 8d21df2

22 files changed

+758
-1277
lines changed

Tests/ApolloInternalTestHelpers/MockNetworkTransport.swift

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ public final class MockNetworkTransport: NetworkTransport {
66
public let mockServer: MockGraphQLServer
77
public let requestChainTransport: RequestChainNetworkTransport
88

9+
public var url: URL { requestChainTransport.endpointURL }
10+
911
public init(
1012
mockServer: MockGraphQLServer = MockGraphQLServer(),
1113
store: ApolloStore
@@ -87,7 +89,7 @@ public final class MockNetworkTransport: NetworkTransport {
8789
}
8890

8991
let httpResponse = HTTPURLResponse(
90-
url: TestURL.mockServer.url,
92+
url: request.url!,
9193
statusCode: 200,
9294
httpVersion: nil,
9395
headerFields: nil

Tests/ApolloTests/ApolloStore+ReaderWriterTests.swift

Lines changed: 0 additions & 11 deletions
This file was deleted.

Tests/ApolloTests/ApolloStore_BatchedLoadTests.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ class ApolloStore_BatchedLoadTests: XCTestCase {
114114
XCTAssertEqual(data.hero?.name, "R2-D2")
115115
XCTAssertEqual(data.hero?.friends?.count, 100)
116116

117+
// 3 loads: ROOT_QUERY.hero, hero.friends, list of friends
117118
XCTAssertEqual(cache.numberOfBatchLoads, 3)
118119
}
119120

Tests/ApolloTests/AutomaticPersistedQueriesTests.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,6 @@ class AutomaticPersistedQueriesTests: XCTestCase, MockResponseProvider {
228228
expectation.to(equal("{\"episode\":\"\(episode.rawValue)\"}"))
229229

230230
case .none:
231-
#warning("TODO: write test to test this case actually happens")
232231
expectation.to(equal("{}"))
233232

234233
case .null:

0 commit comments

Comments
 (0)