[SPARK-8918] [MLLIB] [DOC] Add @since tags to mllib.clustering #8288
Conversation
|
Test build #41166 has finished for PR 8288 at commit
|
|
I made a pass and sent a Pull Request adding the missing tags. Please review and merge the changes (mengxr#3) |
| /** Maps given point to its cluster index. */ | ||
| /** | ||
| * Maps given point to its cluster index. | ||
| * @since 1.4.0 |
There was a problem hiding this comment.
I think 1.5.0 is better? Actually, the method exists in branch-1.4. However, it isn't v1.4.0 and v1.4.1.
|
@MechCoder Alright. Thank you for letting me know. |
Add missing tags to mllib.clustering
| @@ -223,12 +238,16 @@ class LocalLDAModel private[clustering] ( | |||
| * | |||
| * @param documents test corpus to use for calculating log likelihood | |||
| * @return variational lower bound on the log likelihood of the entire corpus | |||
| * @since 1.3.0 | |||
There was a problem hiding this comment.
According to my research , it is 1.5.0. This method was commented out in at least 1.3.0 and 1.4.0. So it might be grepped.
|
Test build #41247 has finished for PR 8288 at commit
|
|
LGTM, minus above two things. |
|
test this please |
|
Test build #41268 has finished for PR 8288 at commit
|
This continues the work from #8256. I removed `since` tags from private/protected/local methods/variables (see 72fdeb6). MechCoder Closes #8256 Author: Xiangrui Meng <[email protected]> Author: Xiaoqing Wang <[email protected]> Author: MechCoder <[email protected]> Closes #8288 from mengxr/SPARK-8918. (cherry picked from commit 5b62bef) Signed-off-by: Xiangrui Meng <[email protected]>
|
Merged into master and branch-1.5. Thanks @XiaoqingWang for the first version and @yu-iskw @MechCoder for review! @XiaoqingWang Could you ping me on the JIRA page? So I can assign the ticket to you. |
This continues the work from #8256. I removed
@sincetags from private/protected/local methods/variables (see 72fdeb6). @MechCoderCloses #8256