-
Notifications
You must be signed in to change notification settings - Fork 28.7k
SPARK-8918 Add @since tags to mllib.clustering #8256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ok to test |
ping @yu-iskw to make another pass |
Alright. I'll check this PR. |
@@ -53,32 +54,48 @@ class GaussianMixtureModel( | |||
|
|||
override protected def formatVersion = "1.0" | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not use tabs in code, use spaces instead and indent correctly.
Test build #41097 has finished for PR 8256 at commit
|
@XiaoqingWang thank you for updating. |
I have updated the code style,please help to review ,thanks |
Test build #41130 has finished for PR 8256 at commit
|
update code style : delete the Whitespace at end of line |
Test build #41134 has finished for PR 8256 at commit
|
/** | ||
* apply discount to weights | ||
* @since 1.2.0 | ||
*/ | ||
BLAS.scal(discount, Vectors.dense(clusterWeights)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. This is not a public method.
@XiaoqingWang I submitted #8288 based on your work, because we want to get this merged soon to unblock SPARK-9864. Thanks for your contribution! |
This continues the work from #8256. I removed `since` tags from private/protected/local methods/variables (see 72fdeb6). MechCoder Closes #8256 Author: Xiangrui Meng <[email protected]> Author: Xiaoqing Wang <[email protected]> Author: MechCoder <[email protected]> Closes #8288 from mengxr/SPARK-8918. (cherry picked from commit 5b62bef) Signed-off-by: Xiangrui Meng <[email protected]>
No description provided.