Skip to content

SPARK-8918 Add @since tags to mllib.clustering #8256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

XiaoqingWang
Copy link

No description provided.

@mengxr
Copy link
Contributor

mengxr commented Aug 18, 2015

ok to test

@mengxr
Copy link
Contributor

mengxr commented Aug 18, 2015

ping @yu-iskw to make another pass

@yu-iskw
Copy link
Contributor

yu-iskw commented Aug 18, 2015

Alright. I'll check this PR.

@@ -53,32 +54,48 @@ class GaussianMixtureModel(

override protected def formatVersion = "1.0"

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use tabs in code, use spaces instead and indent correctly.

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41097 has finished for PR 8256 at commit 6bcb09b.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yu-iskw
Copy link
Contributor

yu-iskw commented Aug 18, 2015

@XiaoqingWang thank you for updating.
dev/lint-scala is a useful tool to check Scala code. You should run it on your local machine before sending a PR and updating a PR. It will help you with identifying validation problems of your code.

@XiaoqingWang
Copy link
Author

I have updated the code style,please help to review ,thanks

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41130 has finished for PR 8256 at commit c679b97.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@XiaoqingWang
Copy link
Author

update code style : delete the Whitespace at end of line

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41134 has finished for PR 8256 at commit e430de9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

/**
* apply discount to weights
* @since 1.2.0
*/
BLAS.scal(discount, Vectors.dense(clusterWeights))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This is not a public method.

@mengxr
Copy link
Contributor

mengxr commented Aug 18, 2015

@XiaoqingWang I submitted #8288 based on your work, because we want to get this merged soon to unblock SPARK-9864. Thanks for your contribution!

asfgit pushed a commit that referenced this pull request Aug 19, 2015
This continues the work from #8256. I removed `since` tags from private/protected/local methods/variables (see 72fdeb6). MechCoder

Closes #8256

Author: Xiangrui Meng <[email protected]>
Author: Xiaoqing Wang <[email protected]>
Author: MechCoder <[email protected]>

Closes #8288 from mengxr/SPARK-8918.

(cherry picked from commit 5b62bef)
Signed-off-by: Xiangrui Meng <[email protected]>
@asfgit asfgit closed this in 5b62bef Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants