[SPARK-7419][Streaming][Tests]Fix CheckpointSuite.recovery with file input stream #7323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| eventually(eventuallyTimeout) { | ||
| // Wait until all files have been recorded and all batches have started | ||
| assert(recordedFiles(ssc) === Seq(1, 2, 3) && batchCounter.getNumStartedBatches === 3) | ||
| } | ||
| clock.advance(batchDuration.milliseconds) |
There was a problem hiding this comment.
This line will add one batch, so I move it here. And because of this line, the clock of the recovery StreamingContext will be 14000ms.
|
Test build #36930 has finished for PR 7323 at commit
|
| @@ -483,7 +486,6 @@ class CheckpointSuite extends TestSuiteBase { | |||
| assert(batchCounter.getNumCompletedBatches === index + numBatchesAfterRestart + 1) | |||
| } | |||
| } | |||
| clock.advance(batchDuration.milliseconds) | |||
There was a problem hiding this comment.
This is not necessary now.
|
I've manually triggered this test a few more times. |
|
Test build #1023 has finished for PR 7323 at commit
|
|
Test build #1021 has finished for PR 7323 at commit
|
|
Test build #1020 has finished for PR 7323 at commit
|
|
Test build #1022 has finished for PR 7323 at commit
|
|
Looks great. Merging into master and 1.4. Thanks Ryan!! |
asfgit
pushed a commit
that referenced
this pull request
Jul 9, 2015
…le input stream Fix this failure: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/2886/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.3,label=centos/testReport/junit/org.apache.spark.streaming/CheckpointSuite/recovery_with_file_input_stream/ To reproduce this failure, you can add `Thread.sleep(2000)` before this line https://github.com/apache/spark/blob/a9c4e29950a14e32acaac547e9a0e8879fd37fc9/streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala#L477 Author: zsxwing <[email protected]> Closes #7323 from zsxwing/SPARK-7419 and squashes the following commits: b3caf58 [zsxwing] Fix CheckpointSuite.recovery with file input stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this failure: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT/2886/AMPLAB_JENKINS_BUILD_PROFILE=hadoop2.3,label=centos/testReport/junit/org.apache.spark.streaming/CheckpointSuite/recovery_with_file_input_stream/
To reproduce this failure, you can add
Thread.sleep(2000)before this linespark/streaming/src/test/scala/org/apache/spark/streaming/CheckpointSuite.scala
Line 477 in a9c4e29