Skip to content

[SPARK-7047] [ml] ml.Model optional parent support #5914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jkbradley
Copy link
Member

Made Model.parent transient. Added Model.hasParent to test for null parent

CC: @mengxr

@SparkQA
Copy link

SparkQA commented May 5, 2015

Test build #31894 has finished for PR 5914 at commit 72c87b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #777 has finished for PR 5914 at commit 72c87b6.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jkbradley
Copy link
Member Author

Something strange...let's try again

@SparkQA
Copy link

SparkQA commented May 7, 2015

Test build #780 has finished for PR 5914 at commit 72c87b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 18, 2015

Test build #33007 has finished for PR 5914 at commit d501774.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class DecimalConversion(precisionInfo: Option[(Int, Int)]) extends JDBCConversion

@jkbradley
Copy link
Member Author

Ping @mengxr We still want the parent to be transient, right? If so, then this should be ready to merge

@mengxr
Copy link
Contributor

mengxr commented May 19, 2015

LGTM. Merged into master and branch-1.4. Thanks!

@asfgit asfgit closed this in fb90273 May 19, 2015
asfgit pushed a commit that referenced this pull request May 19, 2015
Made Model.parent transient.  Added Model.hasParent to test for null parent

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes #5914 from jkbradley/parent-optional and squashes the following commits:

d501774 [Joseph K. Bradley] Made Model.parent transient.  Added Model.hasParent to test for null parent

(cherry picked from commit fb90273)
Signed-off-by: Xiangrui Meng <[email protected]>
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
Made Model.parent transient.  Added Model.hasParent to test for null parent

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes apache#5914 from jkbradley/parent-optional and squashes the following commits:

d501774 [Joseph K. Bradley] Made Model.parent transient.  Added Model.hasParent to test for null parent
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
Made Model.parent transient.  Added Model.hasParent to test for null parent

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes apache#5914 from jkbradley/parent-optional and squashes the following commits:

d501774 [Joseph K. Bradley] Made Model.parent transient.  Added Model.hasParent to test for null parent
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
Made Model.parent transient.  Added Model.hasParent to test for null parent

CC: mengxr

Author: Joseph K. Bradley <[email protected]>

Closes apache#5914 from jkbradley/parent-optional and squashes the following commits:

d501774 [Joseph K. Bradley] Made Model.parent transient.  Added Model.hasParent to test for null parent
@jkbradley jkbradley deleted the parent-optional branch July 25, 2016 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants