-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-7047] [ml] ml.Model optional parent support #5914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #31894 has finished for PR 5914 at commit
|
Test build #777 has finished for PR 5914 at commit
|
Something strange...let's try again |
Test build #780 has finished for PR 5914 at commit
|
72c87b6
to
d501774
Compare
Test build #33007 has finished for PR 5914 at commit
|
Ping @mengxr We still want the parent to be transient, right? If so, then this should be ready to merge |
LGTM. Merged into master and branch-1.4. Thanks! |
Made Model.parent transient. Added Model.hasParent to test for null parent CC: mengxr Author: Joseph K. Bradley <[email protected]> Closes #5914 from jkbradley/parent-optional and squashes the following commits: d501774 [Joseph K. Bradley] Made Model.parent transient. Added Model.hasParent to test for null parent (cherry picked from commit fb90273) Signed-off-by: Xiangrui Meng <[email protected]>
Made Model.parent transient. Added Model.hasParent to test for null parent CC: mengxr Author: Joseph K. Bradley <[email protected]> Closes apache#5914 from jkbradley/parent-optional and squashes the following commits: d501774 [Joseph K. Bradley] Made Model.parent transient. Added Model.hasParent to test for null parent
Made Model.parent transient. Added Model.hasParent to test for null parent CC: mengxr Author: Joseph K. Bradley <[email protected]> Closes apache#5914 from jkbradley/parent-optional and squashes the following commits: d501774 [Joseph K. Bradley] Made Model.parent transient. Added Model.hasParent to test for null parent
Made Model.parent transient. Added Model.hasParent to test for null parent CC: mengxr Author: Joseph K. Bradley <[email protected]> Closes apache#5914 from jkbradley/parent-optional and squashes the following commits: d501774 [Joseph K. Bradley] Made Model.parent transient. Added Model.hasParent to test for null parent
Made Model.parent transient. Added Model.hasParent to test for null parent
CC: @mengxr