Skip to content

[SQL][Minor] make StringComparison extends ExpectsInputTypes #5905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

scwf
Copy link
Contributor

@scwf scwf commented May 5, 2015

make StringComparison extends ExpectsInputTypes and added expectedChildTypes, so do not need override expectedChildTypes in each subclass

@SparkQA
Copy link

SparkQA commented May 5, 2015

Test build #31850 has finished for PR 5905 at commit b374ddf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait StringComparison extends ExpectsInputTypes

@rxin
Copy link
Contributor

rxin commented May 5, 2015

Thanks. Merging.

@asfgit asfgit closed this in 3059291 May 5, 2015
asfgit pushed a commit that referenced this pull request May 5, 2015
make StringComparison extends ExpectsInputTypes and added expectedChildTypes, so do not need override expectedChildTypes in each subclass

Author: wangfei <[email protected]>

Closes #5905 from scwf/ExpectsInputTypes and squashes the following commits:

b374ddf [wangfei] make stringcomparison extends ExpectsInputTypes

(cherry picked from commit 3059291)
Signed-off-by: Reynold Xin <[email protected]>
@scwf scwf deleted the ExpectsInputTypes branch May 5, 2015 22:53
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request May 28, 2015
make StringComparison extends ExpectsInputTypes and added expectedChildTypes, so do not need override expectedChildTypes in each subclass

Author: wangfei <[email protected]>

Closes apache#5905 from scwf/ExpectsInputTypes and squashes the following commits:

b374ddf [wangfei] make stringcomparison extends ExpectsInputTypes
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
make StringComparison extends ExpectsInputTypes and added expectedChildTypes, so do not need override expectedChildTypes in each subclass

Author: wangfei <[email protected]>

Closes apache#5905 from scwf/ExpectsInputTypes and squashes the following commits:

b374ddf [wangfei] make stringcomparison extends ExpectsInputTypes
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
make StringComparison extends ExpectsInputTypes and added expectedChildTypes, so do not need override expectedChildTypes in each subclass

Author: wangfei <[email protected]>

Closes apache#5905 from scwf/ExpectsInputTypes and squashes the following commits:

b374ddf [wangfei] make stringcomparison extends ExpectsInputTypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants