SPARK-1658: Correctly identify if maven is installed and working #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current test is checking the exit code of "tail" rather than "mvn". This new check will make sure that mvn is installed and was able to execute the "version command".
|
Can one of the admins verify this patch? |
|
Seems to be a unit test failure but that should be not be related to this change. |
| VERSION=$(mvn help:evaluate -Dexpression=project.version | grep -v "INFO" | tail -n 1) | ||
| if [ $? == -1 ] ;then | ||
| VERSION_TEXT=$(mvn help:evaluate -Dexpression=project.version 2>/dev/null) | ||
| if [ $? != 0 ] ;then |
There was a problem hiding this comment.
Do you mind fixing the semi-colon spacing (realize it's not related to your change):
if [ $? != 0 ]; then
|
Good catch! Made some small comments. |
|
Jenkins, retest this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
Use "set -o pipefail" to catch all pipeline failures and avoid creating an intermidiate variable.
|
Thanks - I've merged this! |
asfgit
pushed a commit
that referenced
this pull request
May 4, 2014
The current test is checking the exit code of "tail" rather than "mvn". This new check will make sure that mvn is installed and was able to execute the "version command". Author: Rahul Singhal <[email protected]> Closes #580 from rahulsinghaliitd/SPARK-1658 and squashes the following commits: 83c0313 [Rahul Singhal] SPARK-1658: Correctly identify if maven is installed and working bf821b9 [Rahul Singhal] SPARK-1658: Correctly identify if maven is installed and working (cherry picked from commit e97a2e6) Signed-off-by: Patrick Wendell <[email protected]>
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
The current test is checking the exit code of "tail" rather than "mvn". This new check will make sure that mvn is installed and was able to execute the "version command". Author: Rahul Singhal <[email protected]> Closes apache#580 from rahulsinghaliitd/SPARK-1658 and squashes the following commits: 83c0313 [Rahul Singhal] SPARK-1658: Correctly identify if maven is installed and working bf821b9 [Rahul Singhal] SPARK-1658: Correctly identify if maven is installed and working
helenyugithub
pushed a commit
to helenyugithub/spark
that referenced
this pull request
Aug 20, 2019
…ble in Java 9+ (apache#580) ## Upstream SPARK-26963 apache#23866 ## What changes were proposed in this pull request? Don't use inaccessible fields in SizeEstimator, which comes up in Java 9+ ## How was this patch tested? Manually ran tests with Java 11; it causes these tests that failed before to pass. This ought to pass on Java 8 as there's effectively no change for Java 8. Closes apache#23866 from srowen/SPARK-26963. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
bzhaoopenstack
pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
* Fix install-docker role 1. systemctl is not available on Ubuntu 14.04, so using "service docker restart" as a workaround. 2. change option "--r" position in spark-inegration-test-minikube-k8s job to avoid "--r" is bypassed to mvn. Related-Bug: theopenlab/openlab#308 Related-Bug: theopenlab/openlab#310 * Do not install docker when config docker machine Co-authored-by: liu-sheng <[email protected]> * Do not need to clean iptables rules when installing docker I did not found any docs say that need to clean iptables when installing docker, only found in[1]. So I may prefer we do not clean iptables rules unless we really need, and that should be done in where use docker that in docker installation. [1] https://github.com/kubernetes/cloud-provider-openstack/blob/master/devstack/plugin.sh#L98-L107 * Change the order of roles in docker-machine job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test is checking the exit code of "tail" rather than "mvn".
This new check will make sure that mvn is installed and was able to
execute the "version command".