[SPARK-4652][DOCS] Add docs about spark-git-repo option #3513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be some times when WIPS spark version need to be run on EC2 cluster. In order to setup this type of cluster more easily, add --spark-git-repo option description to ec2 documentation.
|
Can one of the admins verify this patch? |
| @@ -85,6 +85,8 @@ another. | |||
| specified version of Spark. The `<version>` can be a version number | |||
| (e.g. "0.7.3") or a specific git hash. By default, a recent | |||
| version will be used. | |||
| - `--spark-git-repo=<repository url>` enables you to run your development version on EC2 cluster. You need to set `--spark-version` | |||
There was a problem hiding this comment.
Can you wrap the text here consistent with the rest of the file?
| development version on EC2 cluster. You need to set | ||
| `--spark-version` as git commit hash such as 317e114 not | ||
| original release version number. By default, this repository is | ||
| set [apache mirror](https://github.com/apache/spark). |
There was a problem hiding this comment.
"Apache" needs to be capitalized here. I'd also swap the order of these sentences so that the default for --spark-git-repo appears first, followed by the sentence describing how --spark-version needs to be set when using this option.
|
This looks good to me. There's one minor sentence-ordering and capitalization issue that I'd like to fix, but I'll do it myself on merge. I'm going to merge this into |
asfgit
pushed a commit
that referenced
this pull request
Dec 4, 2014
There might be some cases when WIPS spark version need to be run on EC2 cluster. In order to setup this type of cluster more easily, add --spark-git-repo option description to ec2 documentation. Author: lewuathe <[email protected]> Author: Josh Rosen <[email protected]> Closes #3513 from Lewuathe/doc-for-development-spark-cluster and squashes the following commits: 6dae8ee [lewuathe] Wrap consistent with other descriptions cfaf9be [lewuathe] Add docs about spark-git-repo option (Editing / cleanup by Josh Rosen) (cherry picked from commit ab8177d) Signed-off-by: Josh Rosen <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 4, 2014
There might be some cases when WIPS spark version need to be run on EC2 cluster. In order to setup this type of cluster more easily, add --spark-git-repo option description to ec2 documentation. Author: lewuathe <[email protected]> Author: Josh Rosen <[email protected]> Closes #3513 from Lewuathe/doc-for-development-spark-cluster and squashes the following commits: 6dae8ee [lewuathe] Wrap consistent with other descriptions cfaf9be [lewuathe] Add docs about spark-git-repo option (Editing / cleanup by Josh Rosen) (cherry picked from commit ab8177d) Signed-off-by: Josh Rosen <[email protected]>
|
@JoshRosen Thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be some cases when WIPS spark version need to be run
on EC2 cluster. In order to setup this type of cluster more easily,
add --spark-git-repo option description to ec2 documentation.