-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-3939][SQL] NPE caused by SessionState.out not set in thriftserver2 #2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
QA tests have started for PR 2812 at commit
|
QA tests have finished for PR 2812 at commit
|
Test FAILed. |
retest this please. |
QA tests have started for PR 2812 at commit
|
@adrian-wang i'm gonna kill the currently running test and retrigger it after i do some maintenance on our jenkins infrastructure. cool? |
Test FAILed. |
jenkins, test this please |
QA tests have started for PR 2812 at commit
|
QA tests have finished for PR 2812 at commit
|
Test FAILed. |
retest this please. |
QA tests have started for PR 2812 at commit
|
QA tests have finished for PR 2812 at commit
|
Test FAILed. |
retest this please. |
Test FAILed. |
retest this please. |
QA tests have started for PR 2812 at commit
|
QA tests have finished for PR 2812 at commit
|
Test PASSed. |
SparkSQLEnv.hiveContext.sessionState.err = | ||
new PrintStream(SparkSQLEnv.hiveContext.outputBuffer, true, "UTF-8") | ||
SparkSQLEnv.hiveContext.sessionState.out = | ||
new PrintStream(SparkSQLEnv.hiveContext.outputBuffer, true, "UTF-8") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of duplicating this code, can we just change the line above to SessionState.start(SparkSQLEnv.hiveContext.sessionState)
. out
and err
would be initialized then. I'm actually not sure why we are creating our own session state here at all instead of using the one provided by the context.
Sorry, didn't notice this PR and also worked on this issue in #2887, which I think is a more fundamental solution. |
Never mind, I'll close this then. |
There would be an NPE caused by SessionState.out not set in thriftserver2.