Skip to content

[SPARK-3939][SQL] NPE caused by SessionState.out not set in thriftserver2 #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

adrian-wang
Copy link
Contributor

There would be an NPE caused by SessionState.out not set in thriftserver2.

@SparkQA
Copy link

SparkQA commented Oct 15, 2014

QA tests have started for PR 2812 at commit e89a7c2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 15, 2014

QA tests have finished for PR 2812 at commit e89a7c2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21764/
Test FAILed.

@adrian-wang
Copy link
Contributor Author

retest this please.

@SparkQA
Copy link

SparkQA commented Oct 15, 2014

QA tests have started for PR 2812 at commit e89a7c2.

  • This patch merges cleanly.

@shaneknapp
Copy link
Contributor

@adrian-wang i'm gonna kill the currently running test and retrigger it after i do some maintenance on our jenkins infrastructure. cool?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21773/
Test FAILed.

@shaneknapp
Copy link
Contributor

jenkins, test this please

@SparkQA
Copy link

SparkQA commented Oct 15, 2014

QA tests have started for PR 2812 at commit e89a7c2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 15, 2014

QA tests have finished for PR 2812 at commit e89a7c2.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21776/
Test FAILed.

@adrian-wang
Copy link
Contributor Author

retest this please.

@SparkQA
Copy link

SparkQA commented Oct 16, 2014

QA tests have started for PR 2812 at commit e89a7c2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 16, 2014

QA tests have finished for PR 2812 at commit e89a7c2.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21791/
Test FAILed.

@adrian-wang
Copy link
Contributor Author

retest this please.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21795/
Test FAILed.

@adrian-wang
Copy link
Contributor Author

retest this please.

@SparkQA
Copy link

SparkQA commented Oct 16, 2014

QA tests have started for PR 2812 at commit e89a7c2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 16, 2014

QA tests have finished for PR 2812 at commit e89a7c2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21796/
Test PASSed.

SparkSQLEnv.hiveContext.sessionState.err =
new PrintStream(SparkSQLEnv.hiveContext.outputBuffer, true, "UTF-8")
SparkSQLEnv.hiveContext.sessionState.out =
new PrintStream(SparkSQLEnv.hiveContext.outputBuffer, true, "UTF-8")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating this code, can we just change the line above to SessionState.start(SparkSQLEnv.hiveContext.sessionState). out and err would be initialized then. I'm actually not sure why we are creating our own session state here at all instead of using the one provided by the context.

@liancheng
Copy link
Contributor

Sorry, didn't notice this PR and also worked on this issue in #2887, which I think is a more fundamental solution.

@adrian-wang
Copy link
Contributor Author

Never mind, I'll close this then.

@adrian-wang adrian-wang deleted the setcommand branch October 29, 2014 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants